| Message ID | 20200224225403.1650656-1-jeremy.linton@arm.com |
|---|---|
| Headers | show |
| Series | Add ACPI bindings to the genet | expand |
On 2/24/20 2:53 PM, Jeremy Linton wrote: > This patch series allows the BCM GENET, as used on the RPi4, > to attach when booted in an ACPI environment. The DSDT entry to > trigger this is seen below. Of note, the first patch adds a > small extension to the mdio layer which allows drivers to find > the mii_bus without firmware assistance. The fifth patch in > the set retrieves the MAC address from the umac registers > rather than carrying it directly in the DSDT. This of course > requires the firmware to pre-program it, so we continue to fall > back on a random one if it appears to be garbage. Thanks for your persistence on this I was able to apply this to the latest net-next tree and give this a spin on a STB chip (which uses DT) and did not see any issues, so: Tested-by: Florian Fainelli <f.fainelli@gmail.com> Thanks!
From: Florian Fainelli <f.fainelli@gmail.com> Date: Mon, 24 Feb 2020 15:09:36 -0800 > On 2/24/20 2:53 PM, Jeremy Linton wrote: >> This patch series allows the BCM GENET, as used on the RPi4, >> to attach when booted in an ACPI environment. The DSDT entry to >> trigger this is seen below. Of note, the first patch adds a >> small extension to the mdio layer which allows drivers to find >> the mii_bus without firmware assistance. The fifth patch in >> the set retrieves the MAC address from the umac registers >> rather than carrying it directly in the DSDT. This of course >> requires the firmware to pre-program it, so we continue to fall >> back on a random one if it appears to be garbage. > > Thanks for your persistence on this I was able to apply this to the > latest net-next tree and give this a spin on a STB chip (which uses DT) > and did not see any issues, so: > > Tested-by: Florian Fainelli <f.fainelli@gmail.com> Series applied, thanks everyone.
This patch series allows the BCM GENET, as used on the RPi4, to attach when booted in an ACPI environment. The DSDT entry to trigger this is seen below. Of note, the first patch adds a small extension to the mdio layer which allows drivers to find the mii_bus without firmware assistance. The fifth patch in the set retrieves the MAC address from the umac registers rather than carrying it directly in the DSDT. This of course requires the firmware to pre-program it, so we continue to fall back on a random one if it appears to be garbage. v1 -> v2: fail on missing phy-mode property replace phy-mode internal property read string with device_get_phy_mode() equivalent rework mac address detection logic so that it merges the acpi/DT case into device_get_mac_address() allowing _DSD mac address properties. some commit messages justifying why phy_find_first() isn't the worst choice for this driver. + Device (ETH0) + { + Name (_HID, "BCM6E4E") + Name (_UID, 0) + Name (_CCA, 0x0) + Method (_STA) + { + Return (0xf) + } + Method (_CRS, 0x0, Serialized) + { + Name (RBUF, ResourceTemplate () + { + Memory32Fixed (ReadWrite, 0xFd580000, 0x10000, ) + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBD } + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBE } + }) + Return (RBUF) + } + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "phy-mode", "rgmii-rxid" }, + } + }) + } Jeremy Linton (6): mdio_bus: Add generic mdio_find_bus() net: bcmgenet: refactor phy mode configuration net: bcmgenet: enable automatic phy discovery net: bcmgenet: Initial bcmgenet ACPI support net: bcmgenet: Fetch MAC address from the adapter net: bcmgenet: reduce severity of missing clock warnings .../net/ethernet/broadcom/genet/bcmgenet.c | 62 +++++++++----- drivers/net/ethernet/broadcom/genet/bcmmii.c | 82 ++++++++++++++----- drivers/net/phy/mdio_bus.c | 17 ++++ include/linux/phy.h | 1 + 4 files changed, 120 insertions(+), 42 deletions(-)