From patchwork Wed Feb 5 08:55:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ong Boon Leong X-Patchwork-Id: 1233715 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48CFlD102yz9sSZ for ; Wed, 5 Feb 2020 19:55:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgBEIze (ORCPT ); Wed, 5 Feb 2020 03:55:34 -0500 Received: from mga09.intel.com ([134.134.136.24]:48635 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgBEIzd (ORCPT ); Wed, 5 Feb 2020 03:55:33 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 00:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="264149167" Received: from unknown (HELO bong5-HP-Z440.png.intel.com) ([10.221.118.166]) by fmsmga002.fm.intel.com with ESMTP; 05 Feb 2020 00:55:29 -0800 From: Ong Boon Leong To: netdev@vger.kernel.org Cc: Tan Tee Min , Voon Weifeng , Giuseppe Cavallaro , Alexandre TORGUE , Jose Abreu , "David S . Miller" , Maxime Coquelin , Joao Pinto , Arnd Bergmann , Alexandru Ardelean , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v4 0/6] net: stmmac: general fixes for Ethernet functionality Date: Wed, 5 Feb 2020 16:55:04 +0800 Message-Id: <20200205085510.32353-1-boon.leong.ong@intel.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks to all feedbacks from community. We updated the patch-series to below:- 1/6: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Use rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume(). 2/6: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/6: Similar to 2/6 patch but it is a fix for XGMAC_VLAN_TAG register as requested by Jose Abreu. 4/6: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set multicast off|on 5/6: Added similar IFF_MULTICAST flag for xgmac2, similar to 4/6. 6/6: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v3:- patch 1/6 - add rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume() patch 3/6 - Added new patch to fix XGMAC_VLAN_TAG register writting v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Ong Boon Leong (1): net: stmmac: xgmac: fix incorrect XGMAC_VLAN_TAG register writting Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++---- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 17 deletions(-)