| Message ID | 20200113234233.33886-1-Jason@zx2c4.com |
|---|---|
| Headers | show |
| Series | skb_list_walk_safe refactoring for net/*'s skb_gso_segment usage | expand |
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: Mon, 13 Jan 2020 18:42:25 -0500 > This patchset adjusts all return values of skb_gso_segment in net/* to > use the new skb_list_walk_safe helper. > > First we fix a minor bug in the helper macro that didn't come up in the > last patchset's uses. Then we adjust several cases throughout net/. The > xfrm changes were a bit hairy, but doable. Reading and thinking about > the code in mac80211 indicates a memory leak, which the commit > addresses. All the other cases were pretty trivial. Series applied, thanks Jason.
This patchset adjusts all return values of skb_gso_segment in net/* to use the new skb_list_walk_safe helper. First we fix a minor bug in the helper macro that didn't come up in the last patchset's uses. Then we adjust several cases throughout net/. The xfrm changes were a bit hairy, but doable. Reading and thinking about the code in mac80211 indicates a memory leak, which the commit addresses. All the other cases were pretty trivial. Jason A. Donenfeld (8): net: skbuff: disambiguate argument and member for skb_list_walk_safe helper net: udp: use skb_list_walk_safe helper for gso segments net: xfrm: use skb_list_walk_safe helper for gso segments net: openvswitch: use skb_list_walk_safe helper for gso segments net: sched: use skb_list_walk_safe helper for gso segments net: ipv4: use skb_list_walk_safe helper for gso segments net: netfilter: use skb_list_walk_safe helper for gso segments net: mac80211: use skb_list_walk_safe helper for gso segments include/linux/skbuff.h | 6 +++--- net/ipv4/ip_output.c | 8 +++----- net/ipv4/udp.c | 3 +-- net/ipv6/udp.c | 3 +-- net/mac80211/tx.c | 13 +++++-------- net/netfilter/nfnetlink_queue.c | 8 +++----- net/openvswitch/datapath.c | 11 ++++------- net/sched/sch_cake.c | 4 +--- net/sched/sch_tbf.c | 4 +--- net/xfrm/xfrm_device.c | 15 ++++----------- net/xfrm/xfrm_output.c | 9 +++------ 11 files changed, 29 insertions(+), 55 deletions(-)