mbox series

[bpf-next,0/2] bpftool/libbpf: Add probe for large INSN limit

Message ID 20191227105346.867-1-mrostecki@opensuse.org
Headers show
Series bpftool/libbpf: Add probe for large INSN limit | expand

Message

Michal Rostecki Dec. 27, 2019, 10:53 a.m. UTC
From: Michal Rostecki <mrostecki@opensuse.org>

This series implements a new BPF feature probe which checks for the
commit c04c0d2b968a ("bpf: increase complexity limit and maximum program
size"), which increases the maximum program size to 1M. It's based on
the similar check in Cilium, althogh Cilium is already aiming to use
bpftool checks and eventually drop all its custom checks.

Examples of outputs:

# bpftool feature probe
[...]
Scanning miscellaneous eBPF features...
Large complexity limit and maximum program size (1M) is available

# bpftool feature probe macros
[...]
/*** eBPF misc features ***/
#define HAVE_HAVE_LARGE_INSN_LIMIT

# bpftool feature probe -j | jq '.["misc"]'
{
  "have_large_insn_limit": true
}

Michal Rostecki (2):
  libbpf: Add probe for large INSN limit
  bpftool: Add misc secion and probe for large INSN limit

 tools/bpf/bpftool/feature.c   | 18 ++++++++++++++++++
 tools/lib/bpf/libbpf.h        |  1 +
 tools/lib/bpf/libbpf.map      |  1 +
 tools/lib/bpf/libbpf_probes.c | 23 +++++++++++++++++++++++
 4 files changed, 43 insertions(+)

Comments

Michal Rostecki Dec. 27, 2019, 6:14 p.m. UTC | #1
On Fri, Dec 27, 2019 at 11:53:44AM +0100, mrostecki@opensuse.org wrote:
> From: Michal Rostecki <mrostecki@opensuse.org>
> 
> This series implements a new BPF feature probe which checks for the
> commit c04c0d2b968a ("bpf: increase complexity limit and maximum program
> size"), which increases the maximum program size to 1M. It's based on
> the similar check in Cilium, althogh Cilium is already aiming to use
> bpftool checks and eventually drop all its custom checks.
> 
> Examples of outputs:
> 
> # bpftool feature probe
> [...]
> Scanning miscellaneous eBPF features...
> Large complexity limit and maximum program size (1M) is available
> 
> # bpftool feature probe macros
> [...]
> /*** eBPF misc features ***/
> #define HAVE_HAVE_LARGE_INSN_LIMIT
> 
> # bpftool feature probe -j | jq '.["misc"]'
> {
>   "have_large_insn_limit": true
> }
> 
> Michal Rostecki (2):
>   libbpf: Add probe for large INSN limit
>   bpftool: Add misc secion and probe for large INSN limit
> 
>  tools/bpf/bpftool/feature.c   | 18 ++++++++++++++++++
>  tools/lib/bpf/libbpf.h        |  1 +
>  tools/lib/bpf/libbpf.map      |  1 +
>  tools/lib/bpf/libbpf_probes.c | 23 +++++++++++++++++++++++
>  4 files changed, 43 insertions(+)
> 
> -- 
> 2.16.4
> 

Sorry for sending this twice! I didn't see the thread immediately after
sending the first time, so I though there is some problem with my
@opensuse.org alias or SMTP server not accepting it. Please review this
series, since I'm using @opensuse.org alias for upstream development
more frequently than @suse.de.