From patchwork Wed Nov 27 07:27:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangbo Lu X-Patchwork-Id: 1201368 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47NC6v2yfWz9sSt for ; Wed, 27 Nov 2019 18:28:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbfK0H2V (ORCPT ); Wed, 27 Nov 2019 02:28:21 -0500 Received: from inva021.nxp.com ([92.121.34.21]:41346 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726078AbfK0H2V (ORCPT ); Wed, 27 Nov 2019 02:28:21 -0500 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id BC8C920018D; Wed, 27 Nov 2019 08:28:19 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id C53B020001F; Wed, 27 Nov 2019 08:28:16 +0100 (CET) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id BC8364028F; Wed, 27 Nov 2019 15:28:12 +0800 (SGT) From: Yangbo Lu To: netdev@vger.kernel.org, Alexandre Belloni , Microchip Linux Driver Support , "David S . Miller" , Vladimir Oltean Cc: Yangbo Lu Subject: [v2, 0/2] net: mscc: ocelot: fix potential issues accessing skbs list Date: Wed, 27 Nov 2019 15:27:55 +0800 Message-Id: <20191127072757.34502-1-yangbo.lu@nxp.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix two prtential issues accessing skbs list. - Break the matching loop when find the matching skb to avoid consuming more skbs incorrectly. The timestamp ID is only from 0 to 3 while the FIFO supports 128 timestamps at most. - Convert to use skb queue instead of the list of skbs to provide protect with lock. --- Changes for v2: - Split into two patches. - Converted to use skb queue. Yangbo Lu (2): net: mscc: ocelot: avoid incorrect consuming in skbs list net: mscc: ocelot: use skb queue instead of skbs list drivers/net/ethernet/mscc/ocelot.c | 55 +++++++++++++------------------------- include/soc/mscc/ocelot.h | 9 +------ 2 files changed, 20 insertions(+), 44 deletions(-)