mbox series

[0/5] net: phy: at803x device tree binding

Message ID 20191102011351.6467-1-michael@walle.cc
Headers show
Series net: phy: at803x device tree binding | expand

Message

Michael Walle Nov. 2, 2019, 1:13 a.m. UTC 
Adds a device tree binding to configure the clock and the RGMII voltage.

Changes since the RFC:
 - renamed the Kconfig entry to "Qualcomm Atheros.." and reordered the
   item
 - renamed the prefix from atheros to qca
 - use the correct name AR803x (instead of AT803x) in new files and
   dt-bindings.
 - listed the PHY maintainers in the new schema. Hopefully, thats ok.
 - fixed a typo in the bindings schema
 - run dtb_checks and dt_binding_check and fixed the schema
 - dropped the rgmii-io-1v8 property; instead provide two regulators vddh
   and vddio, add one consumer vddio-supply
 - fix the clock settings for the AR8030/AR8035
 - only the AR8031 supports chaning the LDO and the PLL mode in software.
   Check if we have the correct PHY.
 - new patch to mention the AR8033 which is the same as the AR8031 just
   without PTP support
 - new patch which corrects any displayed PHY names and comments. Be
   consistent.

Michael Walle (5):
  net: phy: at803x: fix Kconfig description
  dt-bindings: net: phy: Add support for AT803X
  net: phy: at803x: add device tree binding
  net: phy: at803x: mention AR8033 as same as AR8031
  net: phy: at803x: fix the PHY names

 .../devicetree/bindings/net/qca,ar803x.yaml   | 111 +++++++
 MAINTAINERS                                   |   2 +
 drivers/net/phy/Kconfig                       |  10 +-
 drivers/net/phy/at803x.c                      | 301 +++++++++++++++++-
 include/dt-bindings/net/qca-ar803x.h          |  13 +
 5 files changed, 422 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/qca,ar803x.yaml
 create mode 100644 include/dt-bindings/net/qca-ar803x.h

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Simon Horman <simon.horman@netronome.com>

Comments

David Miller Nov. 5, 2019, 10:06 p.m. UTC | #1 
From: Michael Walle <michael@walle.cc>
Date: Sat,  2 Nov 2019 02:13:46 +0100

> Adds a device tree binding to configure the clock and the RGMII voltage.

This does not apply cleanly to net-next, please respin.

Thank you.
Michael Walle Nov. 5, 2019, 10:22 p.m. UTC | #2 
Am 2019-11-05 23:06, schrieb David Miller:
> From: Michael Walle <michael@walle.cc>
> Date: Sat,  2 Nov 2019 02:13:46 +0100
> 
>> Adds a device tree binding to configure the clock and the RGMII 
>> voltage.
> 
> This does not apply cleanly to net-next, please respin.

That is actually just fine, because there is a bug in the AR8035 
handling. I'll fix that and rebase it on your net-next.

Thanks,
-michael