mbox series

[net-next,v2,0/4] ICMP flow improvements

Message ID 20191029135053.10055-1-mcroce@redhat.com
Headers show
Series ICMP flow improvements | expand

Message

Matteo Croce Oct. 29, 2019, 1:50 p.m. UTC 
This series improves the flow inspector handling of ICMP packets:
The first two patches just add some comments in the code which would have saved
me a few minutes of time, and refactor a piece of code.
The third one adds to the flow inspector the capability to extract the
Identifier field, if present, so echo requests and replies are classified
as part of the same flow.
The fourth patch uses the function introduced earlier to the bonding driver,
so echo replies can be balanced across bonding slaves.

v1 -> v2:
 - remove unused struct members
 - add an helper to check for the Id field
 - use a local flow_dissector_key in the bonding to avoid
   changing behaviour of the flow dissector

Matteo Croce (4):
  flow_dissector: add meaningful comments
  flow_dissector: skip the ICMP dissector for non ICMP packets
  flow_dissector: extract more ICMP information
  bonding: balance ICMP echoes in layer3+4 mode

 drivers/net/bonding/bond_main.c |  77 ++++++++++++++++++++---
 include/net/flow_dissector.h    |  20 +++---
 net/core/flow_dissector.c       | 108 +++++++++++++++++++++++---------
 3 files changed, 160 insertions(+), 45 deletions(-)

Comments

David Miller Oct. 31, 2019, 12:21 a.m. UTC | #1 
From: Matteo Croce <mcroce@redhat.com>
Date: Tue, 29 Oct 2019 14:50:49 +0100

> This series improves the flow inspector handling of ICMP packets:
> The first two patches just add some comments in the code which would have saved
> me a few minutes of time, and refactor a piece of code.
> The third one adds to the flow inspector the capability to extract the
> Identifier field, if present, so echo requests and replies are classified
> as part of the same flow.
> The fourth patch uses the function introduced earlier to the bonding driver,
> so echo replies can be balanced across bonding slaves.
> 
> v1 -> v2:
>  - remove unused struct members
>  - add an helper to check for the Id field
>  - use a local flow_dissector_key in the bonding to avoid
>    changing behaviour of the flow dissector

Series applied to net-next, thanks.