From patchwork Wed Oct 23 00:53:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 1181715 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="G3+2N9hR"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46yX232RG5z9sPZ for ; Wed, 23 Oct 2019 11:54:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732139AbfJWAyA (ORCPT ); Tue, 22 Oct 2019 20:54:00 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:39435 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727403AbfJWAx7 (ORCPT ); Tue, 22 Oct 2019 20:53:59 -0400 Received: by mail-pf1-f201.google.com with SMTP id b13so14772537pfp.6 for ; Tue, 22 Oct 2019 17:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=hTNszrLwiWQM9d4qPLewL0yEQ/cfDBLkldVagVLEUe8=; b=G3+2N9hR6CXSywV/BCG9jOzcYqmnnIcMKGmlNKEdFehcbxSmPwGHWUEGPxsOqi0UPp 8M0SlH5BoyojTAmdI60I4dOtJ3aXm2zJJGSdETJyBFUEkUQv9JxUsiYcbWUeWnW6HR9M moMWeOLseXW3m+Ak1+9LsOXvbUUOmsHD1W8OOdKwYcVxOlF4J7ok5HWpf4mmtd3i0SUx jBxJiJYqlILVQ6WdIpWFFB/NYBoD3pg2UcQPJLrNqXMllSQomgO8rX4ZapAE76zjdLjW REN4Hu+gnSTSl53QCKw5BI2Z+WrADhrHAvaBO2pETg5rxfgSXkYFcIhpaoubzbm9GkAj uO8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hTNszrLwiWQM9d4qPLewL0yEQ/cfDBLkldVagVLEUe8=; b=DPOJCNEQ1Bgtt1OlchGroYrTXr01lHkgJPYiLQAd0VhjlYzRo5D07jULxK/ZOy/yVl EORpZyHpykR+JSH9sHowbh8VYUOsaOTthMbSTE6dbq7ek89lW/6kU5DSrCPGhMlsa9mW DNyFE5OPmI2q62w4Q1nRvauF9WpUF170Ncn9BKqCZpeg1yzm7jiurPeiJhR5cluzagQR Sb1paYXnkE160g8OyrgE2jY0lk4Z7cpPDds3JO/gmbWl7jrszguTLt+a/R2nlfDns+Mw I38fqPrgBXPpgKTB47h0rk3UbHiUTJ4qsrTcJ6GgyZ7p6Carfzo3150yPpJJFF6nW9gO Fupw== X-Gm-Message-State: APjAAAX+MGdOUeABf0FPbTdEWZdK+rc4Z2znkp6+Wj9A/bhpSQI4nfUS NOM16cMDSPGW9QHFcTGLTxZW4/pvX4SG X-Google-Smtp-Source: APXvYqzYOzdcq5nCtM6xX1BGWadrzL6Bve96/TmAwvY8X0RhJGLPOQH1XzQWxptmeVhcoCUBfC4g1K9JIAd4 X-Received: by 2002:a63:e255:: with SMTP id y21mr3404951pgj.353.1571792038384; Tue, 22 Oct 2019 17:53:58 -0700 (PDT) Date: Tue, 22 Oct 2019 17:53:28 -0700 In-Reply-To: <20191017170531.171244-1-irogers@google.com> Message-Id: <20191023005337.196160-1-irogers@google.com> Mime-Version: 1.0 References: <20191017170531.171244-1-irogers@google.com> X-Mailer: git-send-email 2.23.0.866.gb869b98d4c-goog Subject: [PATCH v2 0/9] Improvements to memory usage by parse events From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andi Kleen , Jin Yao , Adrian Hunter , Kan Liang , John Garry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Stephane Eranian , Ian Rogers Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The parse events parser leaks memory for certain expressions as well as allowing a char* to reference stack, heap or .rodata. This series of patches improves the hygeine and adds free-ing operations to reclaim memory in the parser in error and non-error situations. The series of patches was generated with LLVM's address sanitizer and libFuzzer: https://llvm.org/docs/LibFuzzer.html called on the parse_events function with randomly generated input. With the patches no leaks or memory corruption issues were present. These patches are preferable to an earlier proposed patch: perf tools: avoid reading out of scope array Ian Rogers (9): perf tools: add parse events append error perf tools: splice events onto evlist even on error perf tools: ensure config and str in terms are unique perf tools: move ALLOC_LIST into a function perf tools: avoid a malloc for array events perf tools: add destructors for parse event terms perf tools: before yyabort-ing free components perf tools: if pmu configuration fails free terms perf tools: add a deep delete for parse event terms tools/perf/util/parse-events.c | 177 ++++++++++----- tools/perf/util/parse-events.h | 3 + tools/perf/util/parse-events.y | 388 ++++++++++++++++++++++++--------- tools/perf/util/pmu.c | 38 ++-- 4 files changed, 431 insertions(+), 175 deletions(-)