From patchwork Mon Oct 21 20:09:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 1180838 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Nm8h80lA"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46xnmm0skxz9sP4 for ; Tue, 22 Oct 2019 07:10:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730253AbfJUUJ6 (ORCPT ); Mon, 21 Oct 2019 16:09:58 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51904 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730104AbfJUUJ6 (ORCPT ); Mon, 21 Oct 2019 16:09:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571688597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GRr4vvR8SMLlGLaQHrzXZBP/1GJnG/hY1lt52vVZ3iU=; b=Nm8h80lA+dV0iqaIGOyKgTd1y/VMRasZAPwov+a6GotDHffinJ1leDct0kL5bEG8xtDPXf wDqKatCVWlYZiGrx6NRtxRxn2Mu7NdHH5NllcmoUxEhrAyLjsmkngkobaiKoqhPsB7DcOC zhGwUmdzmtDiO91jbcUcCrT+cQJzw8o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-rdN_erQeOlyZUnGiLKqm0A-1; Mon, 21 Oct 2019 16:09:54 -0400 Received: by mail-wm1-f69.google.com with SMTP id c188so5079876wmd.9 for ; Mon, 21 Oct 2019 13:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/hTnU2SL18HXqwrFfPhOqj3zVzoYeINRKnKQ1LCV8o0=; b=mD98Ixv/zk2Enb0X+qTev90mED3AB5WbQJW5TD/GtLgp3IkoznLdoaPVJF/VoJUNDx gj5LJ16JMSjlR4wk0vzdJFqSHUMjg6fmWSf6m08YqXhTd+VwyNRimM1MZtFU19x828QT iSTjyWEdh7/qnyn9kjNF1wb+MDadk0TJjshCr9p7TeeVMCiM+D6bAZDiBQVbHvtLWsjr 0L79ZggLB1HitdA/9rJuHzF8o8K15EITQEJwzLvd7vWLvEf3srvosyBq+vEEpDivKiGy IR0iJJqGv7BEVkZ+NRtr73wPGRgVoT3/IhX9ZCUMV3ynHEn5Ty4E99jBVI+TUeRDHTg9 BmWw== X-Gm-Message-State: APjAAAVTlD8GNm50dfLmhGZlzI78Y9f/cL1/SLZfkZXsy/spHsQnhNZ7 bUUS3Ulfo4mhKLjoqm9V3ECxXLw3JhD6GEeTK+6h5x+2tOh1435dsuvikDvCl7m7/tlhaOhDGnq pJmzO+3zaCbVhoKPb X-Received: by 2002:a5d:5609:: with SMTP id l9mr55396wrv.113.1571688592855; Mon, 21 Oct 2019 13:09:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfmZR8HzPKtuiCjhCoyN0qzOEXt2OB3PSphHLqsNZCKo7B/TomBYT5P/XX6wfn6KR6i/zXPQ== X-Received: by 2002:a5d:5609:: with SMTP id l9mr55381wrv.113.1571688592582; Mon, 21 Oct 2019 13:09:52 -0700 (PDT) Received: from turbo.teknoraver.net (net-109-115-41-234.cust.vodafonedsl.it. [109.115.41.234]) by smtp.gmail.com with ESMTPSA id l18sm20701933wrn.48.2019.10.21.13.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 13:09:51 -0700 (PDT) From: Matteo Croce To: netdev@vger.kernel.org Cc: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S . Miller " , Stanislav Fomichev , Daniel Borkmann , Song Liu , Alexei Starovoitov , Paul Blakey , linux-kernel@vger.kernel.org Subject: [PATCH net-next 0/4] ICMP flow improvements Date: Mon, 21 Oct 2019 22:09:44 +0200 Message-Id: <20191021200948.23775-1-mcroce@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-MC-Unique: rdN_erQeOlyZUnGiLKqm0A-1 X-Mimecast-Spam-Score: 0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This series improves the flow inspector handling of ICMP packets: The first two patches just add some comments in the code which would have saved me a few minutes of time, and refactor a piece of code. The third one adds to the flow inspector the capability to extract the Identifier field, if present, so echo requests and replies are classified as part of the same flow. The fourth patch uses the function introduced earlier to the bonding driver, so echo replies can be balanced across bonding slaves. Matteo Croce (4): flow_dissector: add meaningful comments flow_dissector: skip the ICMP dissector for non ICMP packets flow_dissector: extract more ICMP information bonding: balance ICMP echoes in layer3+4 mode drivers/net/bonding/bond_main.c | 22 ++++++-- include/net/flow_dissector.h | 11 +++- net/core/flow_dissector.c | 98 +++++++++++++++++++++++---------- 3 files changed, 95 insertions(+), 36 deletions(-)