mbox series

[net-next,0/4] qed*: Enhancements.

Message ID 20190830074206.8836-1-skalluru@marvell.com
Headers show
Series qed*: Enhancements. | expand

Message

Sudarsana Reddy Kalluru Aug. 30, 2019, 7:42 a.m. UTC
The patch series adds couple of enhancements to qed/qede drivers.
  - Support for dumping the config id attributes via ethtool -w/W.
  - Support for dumping the GRC data of required memory regions using
    ethtool -w/W interfaces.

Patch (1) adds driver APIs for reading the config id attributes.
Patch (2) adds ethtool support for dumping the config id attributes.
Patch (3) adds support for configuring the GRC dump config flags.
Patch (4) adds ethtool support for dumping the grc dump.

Please consider applying it to net-next.

Sudarsana Reddy Kalluru (4):
  qed: Add APIs for reading config id attributes.
  qede: Add support for reading the config id attributes.
  qed: Add APIs for configuring grc dump config flags.
  qede: Add support for dumping the grc data.

 drivers/net/ethernet/qlogic/qed/qed_debug.c     |  82 +++++++++++++++++
 drivers/net/ethernet/qlogic/qed/qed_hsi.h       |  15 ++++
 drivers/net/ethernet/qlogic/qed/qed_main.c      |  48 ++++++++++
 drivers/net/ethernet/qlogic/qed/qed_mcp.c       |  29 ++++++
 drivers/net/ethernet/qlogic/qed/qed_mcp.h       |  15 ++++
 drivers/net/ethernet/qlogic/qede/qede.h         |  15 ++++
 drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 114 ++++++++++++++++++++++++
 include/linux/qed/qed_if.h                      |  20 +++++
 8 files changed, 338 insertions(+)

Comments

Jakub Kicinski Aug. 31, 2019, 5:10 a.m. UTC | #1
On Fri, 30 Aug 2019 00:42:02 -0700, Sudarsana Reddy Kalluru wrote:
> The patch series adds couple of enhancements to qed/qede drivers.
>   - Support for dumping the config id attributes via ethtool -w/W.
>   - Support for dumping the GRC data of required memory regions using
>     ethtool -w/W interfaces.
> 
> Patch (1) adds driver APIs for reading the config id attributes.
> Patch (2) adds ethtool support for dumping the config id attributes.
> Patch (3) adds support for configuring the GRC dump config flags.
> Patch (4) adds ethtool support for dumping the grc dump.

I don't see anything too objectionable here, but without knowing what
GRC stands for etc. examples of what's actually exchanged here, it's
a little hard to judge..
David Miller Aug. 31, 2019, 8:32 p.m. UTC | #2
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Date: Fri, 30 Aug 2019 00:42:02 -0700

> The patch series adds couple of enhancements to qed/qede drivers.
>   - Support for dumping the config id attributes via ethtool -w/W.
>   - Support for dumping the GRC data of required memory regions using
>     ethtool -w/W interfaces.
> 
> Patch (1) adds driver APIs for reading the config id attributes.
> Patch (2) adds ethtool support for dumping the config id attributes.
> Patch (3) adds support for configuring the GRC dump config flags.
> Patch (4) adds ethtool support for dumping the grc dump.
> 
> Please consider applying it to net-next.

Series applied, thanks.