| Message ID | 20190829105645.12285-1-quentin.monnet@netronome.com |
|---|---|
| Headers | show |
| Series | tools: bpftool: improve bpftool build experience | expand |
On Thu, 29 Aug 2019 11:56:42 +0100, Quentin Monnet wrote: > Hi, > This set attempts to make it easier to build bpftool, in particular when > passing a specific output directory. This is a follow-up to the > conversation held last month by Lorenz, Ilya and Jakub [0]. > > The first patch is a minor fix to bpftool's Makefile, regarding the > retrieval of kernel version (which currently prints a non-relevant make > warning on some invocations). > > Second patch improves the Makefile commands to support more "make" > invocations, or to fix building with custom output directory. On Jakub's > suggestion, a script is also added to BPF selftests in order to keep track > of the supported build variants. > > At last, third patch is a sligthly modified version of Ilya's fix regarding > libbpf.a appearing twice on the linking command for bpftool. > > [0] https://lore.kernel.org/bpf/CACAyw9-CWRHVH3TJ=Tke2x8YiLsH47sLCijdp=V+5M836R9aAA@mail.gmail.com/ I think Ilya has a point, but otherwise looks good to me :) Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Hi, This set attempts to make it easier to build bpftool, in particular when passing a specific output directory. This is a follow-up to the conversation held last month by Lorenz, Ilya and Jakub [0]. The first patch is a minor fix to bpftool's Makefile, regarding the retrieval of kernel version (which currently prints a non-relevant make warning on some invocations). Second patch improves the Makefile commands to support more "make" invocations, or to fix building with custom output directory. On Jakub's suggestion, a script is also added to BPF selftests in order to keep track of the supported build variants. At last, third patch is a sligthly modified version of Ilya's fix regarding libbpf.a appearing twice on the linking command for bpftool. [0] https://lore.kernel.org/bpf/CACAyw9-CWRHVH3TJ=Tke2x8YiLsH47sLCijdp=V+5M836R9aAA@mail.gmail.com/ Cc: Lorenz Bauer <lmb@cloudflare.com> Cc: Ilya Leoshkevich <iii@linux.ibm.com> Cc: Jakub Kicinski <jakub.kicinski@netronome.com> Quentin Monnet (3): tools: bpftool: ignore make built-in rules for getting kernel version tools: bpftool: improve and check builds for different make invocations tools: bpftool: do not link twice against libbpf.a in Makefile tools/bpf/bpftool/Makefile | 18 ++- tools/testing/selftests/bpf/Makefile | 3 +- .../selftests/bpf/test_bpftool_build.sh | 137 ++++++++++++++++++ 3 files changed, 149 insertions(+), 9 deletions(-) create mode 100755 tools/testing/selftests/bpf/test_bpftool_build.sh