Message ID | 20190709141735.19193-1-michal.kalderon@marvell.com |
---|---|
Headers | show |
Series | RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA | expand |
On 09/07/2019 17:17, Michal Kalderon wrote: > This patch series uses the doorbell overflow recovery mechanism > introduced in > commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") > for rdma ( RoCE and iWARP ) > > The first three patches modify the core code to contain helper > functions for managing mmap_xa inserting, getting and freeing > entries. The code was taken almost as is from the efa driver. > There is still an open discussion on whether we should take > this even further and make the entire mmap generic. Until a > decision is made, I only created the database API and modified > the efa and qedr driver to use it. The doorbell recovery code will be based > on the common code. > > Efa driver was compile tested only. For the whole series: Tested-by: Gal Pressman <galpress@amazon.com>
> From: linux-rdma-owner@vger.kernel.org <linux-rdma- > owner@vger.kernel.org> On Behalf Of Gal Pressman > > On 09/07/2019 17:17, Michal Kalderon wrote: > > This patch series uses the doorbell overflow recovery mechanism > > introduced in commit 36907cd5cd72 ("qed: Add doorbell overflow > > recovery mechanism") for rdma ( RoCE and iWARP ) > > > > The first three patches modify the core code to contain helper > > functions for managing mmap_xa inserting, getting and freeing entries. > > The code was taken almost as is from the efa driver. > > There is still an open discussion on whether we should take this even > > further and make the entire mmap generic. Until a decision is made, I > > only created the database API and modified the efa and qedr driver to > > use it. The doorbell recovery code will be based on the common code. > > > > Efa driver was compile tested only. > > For the whole series: > Tested-by: Gal Pressman <galpress@amazon.com> Thanks Gal!
On Tue, Jul 09, 2019 at 05:17:29PM +0300, Michal Kalderon wrote: > This patch series uses the doorbell overflow recovery mechanism > introduced in > commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") > for rdma ( RoCE and iWARP ) > > The first three patches modify the core code to contain helper > functions for managing mmap_xa inserting, getting and freeing > entries. The code was taken almost as is from the efa driver. > There is still an open discussion on whether we should take > this even further and make the entire mmap generic. Until a > decision is made, I only created the database API and modified > the efa and qedr driver to use it. The doorbell recovery code will be based > on the common code. > > Efa driver was compile tested only. > > rdma-core pull request #493 > > Changes from V5: > - Switch between driver dealloc_ucontext and mmap_entries_remove. > - No need to verify the key after using the key to load an entry from > the mmap_xa. > - Change mmap_free api to pass an 'entry' object. > - Add documentation for mmap_free and for newly exported functions. > - Fix some extra/missing line breaks. Lets do SIW now as well, it has the same xa scheme copied from EFA Thanks, Jason
> From: Jason Gunthorpe <jgg@ziepe.ca> > Sent: Thursday, July 25, 2019 9:02 PM > > External Email > > ---------------------------------------------------------------------- > On Tue, Jul 09, 2019 at 05:17:29PM +0300, Michal Kalderon wrote: > > This patch series uses the doorbell overflow recovery mechanism > > introduced in commit 36907cd5cd72 ("qed: Add doorbell overflow > > recovery mechanism") for rdma ( RoCE and iWARP ) > > > > The first three patches modify the core code to contain helper > > functions for managing mmap_xa inserting, getting and freeing entries. > > The code was taken almost as is from the efa driver. > > There is still an open discussion on whether we should take this even > > further and make the entire mmap generic. Until a decision is made, I > > only created the database API and modified the efa and qedr driver to > > use it. The doorbell recovery code will be based on the common code. > > > > Efa driver was compile tested only. > > > > rdma-core pull request #493 > > > > Changes from V5: > > - Switch between driver dealloc_ucontext and mmap_entries_remove. > > - No need to verify the key after using the key to load an entry from > > the mmap_xa. > > - Change mmap_free api to pass an 'entry' object. > > - Add documentation for mmap_free and for newly exported functions. > > - Fix some extra/missing line breaks. > > Lets do SIW now as well, it has the same xa scheme copied from EFA ok > > Thanks, > Jason