[bpf,v5,0/2] xdp: fix hang while unregistering device bound to xdp socket

Message ID	20190627101529.11234-1-i.maximets@samsung.com
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Ilya Maximets <i.maximets@samsung.com> To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, =?utf-8?b?QmrDtnJuIFTDtnBl?= =?utf-8?q?l?= <bjorn.topel@intel.com>, Magnus Karlsson <magnus.karlsson@intel.com>, Jonathan Lemon <jonathan.lemon@gmail.com>, Jakub Kicinski <jakub.kicinski@netronome.com>, Daniel Borkmann <daniel@iogearbox.net>, Ilya Maximets <i.maximets@samsung.com> Subject: [PATCH bpf v5 0/2] xdp: fix hang while unregistering device bound to xdp socket Date: Thu, 27 Jun 2019 13:15:27 +0300 Message-Id: <20190627101529.11234-1-i.maximets@samsung.com> Content-Type: text/plain; charset="utf-8" CMS-TYPE: 201P References: <CGME20190627101535eucas1p27da11c25b0e15474e4c957053de139d9@eucas1p2.samsung.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	xdp: fix hang while unregistering device bound to xdp socket \| expand [bpf,v5,0/2] xdp: fix hang while unregistering device bound to xdp socket [bpf,v5,1/2] xdp: hold device for umem regardless of zero-copy mode [bpf,v5,2/2] xdp: fix hang while unregistering device bound to xdp socket

Message ID

20190627101529.11234-1-i.maximets@samsung.com

Headers

From: Ilya Maximets <i.maximets@samsung.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	xdp-newbies@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	=?utf-8?b?QmrDtnJuIFTDtnBl?= =?utf-8?q?l?= <bjorn.topel@intel.com>,
	Magnus Karlsson <magnus.karlsson@intel.com>, Jonathan Lemon
	<jonathan.lemon@gmail.com>, Jakub Kicinski
	<jakub.kicinski@netronome.com>, Daniel Borkmann <daniel@iogearbox.net>, 
	Ilya Maximets <i.maximets@samsung.com>
Subject: [PATCH bpf v5 0/2] xdp: fix hang while unregistering device bound
	to xdp socket
Date: Thu, 27 Jun 2019 13:15:27 +0300
Message-Id: <20190627101529.11234-1-i.maximets@samsung.com>
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20190627101535eucas1p27da11c25b0e15474e4c957053de139d9@eucas1p2.samsung.com>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk

Series

xdp: fix hang while unregistering device bound to xdp socket | expand

Message

Ilya Maximets June 27, 2019, 10:15 a.m. UTC

Version 5:

    * Fixed incorrect handling of rtnl_lock.

Version 4:

    * 'xdp_umem_clear_dev' exposed to be used while unregistering.
    * Added XDP socket state to track if resources already unbinded.
    * Splitted in two fixes.

Version 3:

    * Declaration lines ordered from longest to shortest.
    * Checking of event type moved to the top to avoid unnecessary
      locking.

Version 2:

    * Completely re-implemented using netdev event handler.

Ilya Maximets (2):
  xdp: hold device for umem regardless of zero-copy mode
  xdp: fix hang while unregistering device bound to xdp socket

 include/net/xdp_sock.h |  5 +++
 net/xdp/xdp_umem.c     | 21 +++++-----
 net/xdp/xdp_umem.h     |  1 +
 net/xdp/xsk.c          | 87 ++++++++++++++++++++++++++++++++++++------
 4 files changed, 93 insertions(+), 21 deletions(-)