mbox series

[v2,net,0/2] Fixes for DSA tagging using 802.1Q

Message ID 20190529214231.10485-1-olteanv@gmail.com
Headers show
Series Fixes for DSA tagging using 802.1Q | expand

Message

Vladimir Oltean May 29, 2019, 9:42 p.m. UTC 
During the prototyping for the "Decoupling PHYLINK from struct
net_device" patchset, the CPU port of the sja1105 driver was moved to a
different spot.  This uncovered an issue in the tag_8021q DSA code,
which used to work by mistake - the CPU port was the last hardware port
numerically, and this was masking an ordering issue which is very likely
to be seen in other drivers that make use of 802.1Q tags.

A question was also raised whether the VID numbers bear any meaning, and
the conclusion was that they don't, at least not in an absolute sense.
The second patch defines bit fields inside the DSA 802.1Q VID so that
tcpdump can decode it unambiguously (although the meaning is now clear
even by visual inspection).

Ioana Ciornei (1):
  net: dsa: tag_8021q: Change order of rx_vid setup

Vladimir Oltean (1):
  net: dsa: tag_8021q: Create a stable binary format

 net/dsa/tag_8021q.c | 79 +++++++++++++++++++++++++++++++++++++--------
 1 file changed, 65 insertions(+), 14 deletions(-)

Comments

David Miller May 30, 2019, 9:47 p.m. UTC | #1 
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 30 May 2019 00:42:29 +0300

> During the prototyping for the "Decoupling PHYLINK from struct
> net_device" patchset, the CPU port of the sja1105 driver was moved to a
> different spot.  This uncovered an issue in the tag_8021q DSA code,
> which used to work by mistake - the CPU port was the last hardware port
> numerically, and this was masking an ordering issue which is very likely
> to be seen in other drivers that make use of 802.1Q tags.
> 
> A question was also raised whether the VID numbers bear any meaning, and
> the conclusion was that they don't, at least not in an absolute sense.
> The second patch defines bit fields inside the DSA 802.1Q VID so that
> tcpdump can decode it unambiguously (although the meaning is now clear
> even by visual inspection).

Series applied.