From patchwork Thu Apr 11 10:26:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 1083848 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44fxyl4f2tz9ryj for ; Thu, 11 Apr 2019 20:26:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbfDKK0h (ORCPT ); Thu, 11 Apr 2019 06:26:37 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:54339 "EHLO mail-wm1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbfDKK0h (ORCPT ); Thu, 11 Apr 2019 06:26:37 -0400 Received: by mail-wm1-f54.google.com with SMTP id c1so6015352wml.4 for ; Thu, 11 Apr 2019 03:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=upxuSzl8ts75jePk9o3fYI4f2ELljxItH89iTEJdUXs=; b=Lfn3eVQ/Rzl4MbXY4RFXyYl4FHlhtj6Mp0gvyf6woJUNxXhF3HL1dK9e/TDabkEWgS LU8WeOsRuAeHnWXctM3g05tlJK3YvY3fhEn2mLcGRZONr6D+wWC8snspJMq6P3i1fE3K ag9lwWSCdRoh0cAbwDiXEI9Sb79ZZ8/r1OZxRn0tkQKVMNIb6FSlSMjod28d6qIQmT7A SyPNSrPkMP+yc8NUDodDOxhfyHWlxYOPk5OT7ddGhfut9EP7AAdSXj7wJ3/Ro4LC/Ld2 t9FSgqrVpX2V5+3OehBWVxBYMMR8E3e4Mv0k7EOSyimpVt3wD477aXGGCPGkbOOXqDxh nbMg== X-Gm-Message-State: APjAAAWLcrq/BQJiunGL7LGi9kV0gZvWsK7gwLn9XiNsKTNQ1CMqQ0jF g9OwSUI1kSAzWk+/MfrQrBvFuoIBhMk= X-Google-Smtp-Source: APXvYqyvO4a/tjR5vqNBY19OEZZN1uUl8T5dSF5BaOoYUsS1qOy3YmALobhqEBMiENF9kpJfUfDxWA== X-Received: by 2002:a1c:ca06:: with SMTP id a6mr6335020wmg.14.1554978395353; Thu, 11 Apr 2019 03:26:35 -0700 (PDT) Received: from mcroce-redhat.mxp.redhat.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id 204sm7681684wmc.1.2019.04.11.03.26.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 03:26:34 -0700 (PDT) From: Matteo Croce To: netdev@vger.kernel.org Cc: Sunil Goutham , Robert Richter , linux-arm-kernel@lists.infradead.org, Ilias Apalodimas , Jesper Dangaard Brouer , David Miller Subject: [PATCH v3 0/2] Fix thunderx MTU with XDP Date: Thu, 11 Apr 2019 12:26:31 +0200 Message-Id: <20190411102633.3685-1-mcroce@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The thunderx driver can't use XDP with all MTU values. This patches sets the right MTU values, and add a check to avoid setting a wrong value which will not function. v3: Fix a copy-paste from two functions, tested on proper hardware: # ip link show dev enP2p1s0v0 2: enP2p1s0v0: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 1c:1b:0d:0d:52:a4 brd ff:ff:ff:ff:ff:ff # ip link set enP2p1s0v0 mtu 1800 # ip link set dev enP2p1s0v0 xdpdrv object mtu.o [ 787.019730] nicvf 0002:01:00.1 enP2p1s0v0: Jumbo frames not yet supported with XDP, current MTU 1800. RTNETLINK answers: Operation not supported # ip link set enP2p1s0v0 mtu 1500 # ip link set dev enP2p1s0v0 xdpdrv object mtu.o [ 800.574568] nicvf 0002:01:00.1 enP2p1s0v0: Link is Up 10000 Mbps Full duplex # ip link set enP2p1s0v0 mtu 1600 [ 807.248321] nicvf 0002:01:00.1 enP2p1s0v0: Jumbo frames not yet supported with XDP, current MTU 1500. RTNETLINK answers: Invalid argument Matteo Croce (2): net: thunderx: raise XDP MTU to 1508 net: thunderx: don't allow jumbo frames with XDP .../net/ethernet/cavium/thunder/nicvf_main.c | 22 +++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)