mbox series

[net-next,0/2] qed* enhancements.

Message ID 20190320072626.31589-1-skalluru@marvell.com
Headers show
Series qed* enhancements. | expand

Message

Sudarsana Reddy Kalluru March 20, 2019, 7:26 a.m. UTC 
The patch series adds couple of enhancements for qed/qede drivers.
Please consider applying it to 'net-next' tree.

Sudarsana Reddy Kalluru (2):
  qede: Populate mbi version in ethtool driver query data.
  qed: Define new MF bit for no_vlan config

 drivers/net/ethernet/qlogic/qed/qed.h           |  3 +++
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c      |  4 +---
 drivers/net/ethernet/qlogic/qed/qed_dev.c       |  6 ++++--
 drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 24 +++++++++++++++++++-----
 4 files changed, 27 insertions(+), 10 deletions(-)

Comments

David Miller March 20, 2019, 6:13 p.m. UTC | #1 
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Date: Wed, 20 Mar 2019 00:26:24 -0700

> The patch series adds couple of enhancements for qed/qede drivers.
> Please consider applying it to 'net-next' tree.
> 
> Sudarsana Reddy Kalluru (2):
>   qede: Populate mbi version in ethtool driver query data.
>   qed: Define new MF bit for no_vlan config

Series appied.

I don't know how big your MBI version strings are, but if you are printing
now both it and the MFW versions into that one string you might hit the
ETHTOOL_FWVERS_LEN limit often.

Just a thought...
Sudarsana Reddy Kalluru March 21, 2019, 4:53 a.m. UTC | #2 
> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Wednesday, March 20, 2019 11:44 PM
> To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Cc: netdev@vger.kernel.org; Ariel Elior <aelior@marvell.com>; Michal
> Kalderon <mkalderon@marvell.com>
> Subject: Re: [PATCH net-next 0/2] qed* enhancements.
> 
> From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Date: Wed, 20 Mar 2019 00:26:24 -0700
> 
> > The patch series adds couple of enhancements for qed/qede drivers.
> > Please consider applying it to 'net-next' tree.
> >
> > Sudarsana Reddy Kalluru (2):
> >   qede: Populate mbi version in ethtool driver query data.
> >   qed: Define new MF bit for no_vlan config
> 
> Series appied.
> 
> I don't know how big your MBI version strings are, but if you are printing now
> both it and the MFW versions into that one string you might hit the
> ETHTOOL_FWVERS_LEN limit often.
> 
> Just a thought...

Dave,
   Thanks for your comments and accepting the changes. Size of mbi version string is 7 bytes and the mfw is 10 bytes. Hence the total string size including the spaces would be under ETHTOOL_FWVERS_LEN.

Thanks,
Sudarsana