From patchwork Mon Feb 25 10:20:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047645 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pIfZsbBZ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J1y1T0rz9ryj for ; Mon, 25 Feb 2019 21:23:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726686AbfBYKXc (ORCPT ); Mon, 25 Feb 2019 05:23:32 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38459 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKXb (ORCPT ); Mon, 25 Feb 2019 05:23:31 -0500 Received: by mail-pf1-f193.google.com with SMTP id n125so4306609pfn.5 for ; Mon, 25 Feb 2019 02:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0KfnnzKtHVM5T8ydse+3NNkGnNYxVL68w3/Uy+dqyHM=; b=pIfZsbBZi58zlXg7xlfBSBWxg0WyZPoL73ZWcM1cibOoZQOVdrFn8I7N3qKhRPHYLh RO+iPhHWionCG/+GYCoiSEuSVLpA9ZW7ZhR8urbZFNA2ngGMmX0HQmczXc9+VF8BXvWE /JlhqGdqhgRbjl6mSLdq1tT7u7UHXIZmDkKliNMjxtU0//0nbKhwSyuCHxd7DfvNqXCf WG9TnMLscfe3sQHlS1HhqpiqvlHwNke9z7+4aqp4XDKGtZjEkwvVe8CQcBMuFSAHon0L 16knpvEJKnS9OycyRfAqpF3+kDss6ytLeqixp3uZbe6L8t6tG1ijTFqz54DiE2WYFfPI nFTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0KfnnzKtHVM5T8ydse+3NNkGnNYxVL68w3/Uy+dqyHM=; b=UgntGzerlT+DoFtei0hpRjLVVqgE22OlrcvSHq9+JfJUUpkKY9o+dtkXBffRJC/bEm uHfBPSgO+HYe0M6B2pEu40O5j9NOsB4yzVn0UnhYCjFCRhO6R5nau8YheEAXO9+JOCW6 L7ZYJsHRJhsUJ+QZdmiGVQ5n2Q4VdHtklIR5qD6vxWJ2CvS/feOkUXDCp5acgh0gZsij aHcWmLv1YEnFYANMvstLBjBwM76eETS163Ne6Mqb4ThGLL+qVR8nay87/fcY1QBc+Py2 iAB7oixDTeP6YMfSdo/kf+fnyHLlYktkzfbYrPO3wLHX/y6qp3xsg4yauzrBOjt/v8Ox 80fA== X-Gm-Message-State: AHQUAua1ZSeUQVC0a8mQR1ch/PcjCL5M16pbz3842FPgRKO/oW1Mit2O 0JWWqF5S3O4VGeLO/Ju3wKI= X-Google-Smtp-Source: AHgI3Ib9veQU4PZ4YfkxOzFsyd2DEtrzaEeQ/TUp7h8T9gV5m6okoskg9To+wuwRE/itGGzkqF6xtw== X-Received: by 2002:a63:7909:: with SMTP id u9mr18697915pgc.243.1551090210879; Mon, 25 Feb 2019 02:23:30 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.23.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:23:30 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, Leslie Monis Subject: [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033 Date: Mon, 25 Feb 2019 15:50:44 +0530 Message-Id: <20190225102051.12268-1-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The current implementation of the PIE queuing discipline is according to the IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been proposed in RFC 8033, which have not yet been incorporated in the source code of Linux. This patch series helps in achieving the same. Performance tests carried out using Flent [https://flent.org/] Changes from v1 to v2: - Excluded the patch setting PIE dynamically active/inactive as the test results were unsatisfactory - Fixed a scaling issue when adding more auto-tuning cases which caused local variables to underflow - Changed the long if/else chain to a loop as suggested by Stephen - Changed the position of the accu_prob variable in the pie_vars structure as recommended by Stephen Mohit P. Tahiliani (7): net: sched: pie: change value of QUEUE_THRESHOLD net: sched: pie: change default value of pie_params->target net: sched: pie: change default value of pie_params->tupdate net: sched: pie: change initial value of pie_vars->burst_time net: sched: pie: add more cases to auto-tune alpha and beta net: sched: pie: add derandomization mechanism net: sched: pie: update references include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c | 107 ++++++++++++++++++++------------- 2 files changed, 66 insertions(+), 43 deletions(-) Acked-by: Dave Taht Acked-by: Jamal Hadi Salim