Message ID | 20190104143411.95519-1-sgarzare@redhat.com |
---|---|
Headers | show |
Series | vsock/virtio: fix issues on device hot-unplug | expand |
Kindly ping :) On Fri, Jan 4, 2019 at 3:34 PM Stefano Garzarella <sgarzare@redhat.com> wrote: > > These patches try to handle the hot-unplug of vsock virtio transport device in > a proper way. > > Maybe move the vsock_core_init()/vsock_core_exit() functions in the module_init > and module_exit of vsock_virtio_transport module can't be the best way, but the > architecture of vsock_core forces us to this approach for now. > > The vsock_core proto_ops expect a valid pointer to the transport device, so we > can't call vsock_core_exit() until there are open sockets. > > Another (little more complex) approach during the device removal, could be to > unregister the AF_VSOCK protocol, then reset all sockets and wait for their > destruction. At this point, we can set the transport pointer to NULL. > > Any suggestions would be helpful. > > v1 -> v2: > - Fixed commit message of patch 1. > > Stefano Garzarella (2): > vsock/virtio: fix kernel panic after device hot-unplug > vsock/virtio: reset connected sockets on device removal > > net/vmw_vsock/virtio_transport.c | 29 +++++++++++++++++++++-------- > 1 file changed, 21 insertions(+), 8 deletions(-) > > -- > 2.20.1 >
On Tue, Jan 29, 2019 at 04:33:58PM +0100, Stefano Garzarella wrote:
> Kindly ping :)
Hi Stefano,
It probably didn't get picked up due to the "RFC" (Request for
Comments).
I suggest rebasing, retesting, and resending to be sure it will be
noticed and merged without conflicts.
Stefan
On Fri, Feb 01, 2019 at 04:19:41PM +0800, Stefan Hajnoczi wrote: > On Tue, Jan 29, 2019 at 04:33:58PM +0100, Stefano Garzarella wrote: > > Kindly ping :) > > Hi Stefano, > It probably didn't get picked up due to the "RFC" (Request for > Comments). > > I suggest rebasing, retesting, and resending to be sure it will be > noticed and merged without conflicts. > Hi Stefan, I will send a v3 following your suggestions! Thanks, Stefano