From patchwork Fri Oct 12 13:42:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Safonov X-Patchwork-Id: 983062 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=arista.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arista.com header.i=@arista.com header.b="GUKqwg38"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42Wptr1s1Jz9s3C for ; Sat, 13 Oct 2018 00:42:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbeJLVP1 (ORCPT ); Fri, 12 Oct 2018 17:15:27 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:41407 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728574AbeJLVP1 (ORCPT ); Fri, 12 Oct 2018 17:15:27 -0400 Received: by mail-ed1-f68.google.com with SMTP id x31-v6so11520302edd.8 for ; Fri, 12 Oct 2018 06:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=from:to:cc:subject:date:message-id; bh=9kl+AFhdfAuyYLrIxjH1tHnSVPLXqMk9wXDpKHphUiw=; b=GUKqwg38yWeBSUKo4vOp+XTPjirRVvA0NvpjqsNjLskgUI/n0EHcmsG6C6BPeHqhUj vsuSdAwIQuBg0mbuw/t0QPyzmSAvOEidNtW5wDLQ8/ipDa8h6U9gqS1tcVNFg6UsU1ez bSSLoCLVIXTKhc3p0pnFDxqRBNW42ppbc1UA2d0vD4lCi+JAaW25XkbG8SBvq6GD2ZHX W/6+OQ2S9esc3h6nxdL619sxOGg0Jfs4YBGS1JOviMuDR1DFqefBHQeDjxVaN2tEMCKz EK6sxoGJIjbd76Rr6WFS6IshgATTLacLEog6emY83kIZn2eFUehzkpEhHqJMMlu2UZI1 Myfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9kl+AFhdfAuyYLrIxjH1tHnSVPLXqMk9wXDpKHphUiw=; b=TKzNK4tSFJ4bYesV1ZzIBjPdsL/4Z1o/vE7vj1OJgRPaqiBUaywjOUFPlFdzNy0D+j yHKocMLj48OG1rrKgQ1I1IsCelLYEi8eCzEJqhSw7WrLPunW/eWHa5QlPZkJIdrK8YxT HklvnEE6EpFtyQcNFt+NYP6qw+6P05RaXzKE2P4IdOBtkaMtZ6l1loWMz/M3yVpkg5BQ EoUq4rKMwxmCyG53ArU64rLru5x+uPx/Ms/DCR/YVQWTDEisPFq+cA8y+O+t0MQvoBQf kn1o46FPCH0+7OeyYXfY43VUguqXdLA71FAvPlxaBocUG2cPzbmtPbqMCs1Ztz8oevdc yZyg== X-Gm-Message-State: ABuFfohYJJql5Dbr9+fpLOaSPCyRUdFBjlg6nZsDW73fRWhYHZwQkdy/ RVw2gTVqqLj9YqKWu2tJuNhZmQ== X-Google-Smtp-Source: ACcGV63iIyQoOyt/YpQ4LhjCIv7bgdXSTZbkqb7cNJtL5/FfjsGaGJ2BVzIy2RqGn28PY+245T0SFg== X-Received: by 2002:a50:8881:: with SMTP id d1-v6mr8746464edd.156.1539351775147; Fri, 12 Oct 2018 06:42:55 -0700 (PDT) Received: from dhcp.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id k42-v6sm577292ede.94.2018.10.12.06.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 06:42:54 -0700 (PDT) From: Dmitry Safonov To: linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Dmitry Safonov , Ard Biesheuvel , Andy Lutomirsky , "David S. Miller" , Herbert Xu , "H. Peter Anvin" , Ingo Molnar , John Stultz , "Kirill A. Shutemov" , Oleg Nesterov , Steffen Klassert , Stephen Boyd , Steven Rostedt , Thomas Gleixner , x86@kernel.org, linux-efi@vger.kernel.org, netdev@vger.kernel.org Subject: [RFC-resend 0/2] compat: in_compat_syscall() differs on x86 Date: Fri, 12 Oct 2018 14:42:51 +0100 Message-Id: <20181012134253.23266-1-dima@arista.com> X-Mailer: git-send-email 2.13.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Reading xfrm (ipsec) code I've found such code: : #ifdef CONFIG_COMPAT : if (in_compat_syscall()) : return -EOPNOTSUPP; : #endif While I can read that it's false on native i386, it's a bit misleading and in result it's better to introduce a helper for that. Grepping other code, I've found that there are already such helpers. And the uniq behavior of in_compat_syscall() on x86 is disturbing. Adjusting it to generic with the following.. (on the first non-resend RFC I managed to forget Cc'ing Andy.. sorry about that, was sure I did add him). Cc: Ard Biesheuvel Cc: Andy Lutomirsky Cc: "David S. Miller" Cc: Herbert Xu Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: John Stultz Cc: "Kirill A. Shutemov" Cc: Oleg Nesterov Cc: Steffen Klassert Cc: Stephen Boyd Cc: Steven Rostedt Cc: Thomas Gleixner Cc: x86@kernel.org Cc: linux-efi@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com> Dmitry Safonov (2): x86/compat: Adjust in_compat_syscall() to generic code under !COMPAT compat: Cleanup in_compat_syscall() callers arch/x86/include/asm/compat.h | 9 ++++++++- arch/x86/include/asm/ftrace.h | 4 +--- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/sys_x86_64.c | 11 ++++++----- arch/x86/mm/hugetlbpage.c | 4 ++-- arch/x86/mm/mmap.c | 2 +- drivers/firmware/efi/efivars.c | 16 ++++------------ include/linux/compat.h | 4 ++-- kernel/time/time.c | 2 +- net/xfrm/xfrm_state.c | 2 -- net/xfrm/xfrm_user.c | 2 -- 11 files changed, 27 insertions(+), 33 deletions(-)