From patchwork Tue Aug 21 15:35:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahmad Fatoum X-Patchwork-Id: 960518 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41vvsJ1B15z9s5b for ; Wed, 22 Aug 2018 01:36:04 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727882AbeHUS4j (ORCPT ); Tue, 21 Aug 2018 14:56:39 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:50153 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeHUS4j (ORCPT ); Tue, 21 Aug 2018 14:56:39 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fs8hK-0003R3-Va; Tue, 21 Aug 2018 17:35:58 +0200 Received: from afa by dude.hi.pengutronix.de with local (Exim 4.91) (envelope-from ) id 1fs8hG-0008Rz-Jx; Tue, 21 Aug 2018 17:35:54 +0200 From: Ahmad Fatoum To: Andrew Lunn , "David S. Miller" , Nicolas Ferre Cc: kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org, Brad Mouring , Florian Fainelli Subject: [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Date: Tue, 21 Aug 2018 17:35:47 +0200 Message-Id: <20180821153548.11223-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.18.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: afa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke initializing macb on the EVB-KSZ9477 eval board. The board's SoC has a macb MAC connected to the KSZ9477 over RGMII, this is represented as a fixed-link as follows in the (non-mainline) device tree: macb0: ethernet@f0028000 { phy-mode = "rgmii"; gpios = <&pioB 28 GPIO_ACTIVE_LOW>; reset-gpios = <&pioC 31 GPIO_ACTIVE_LOW>; status = "okay"; fixed-link { speed = <1000>; full-duplex; }; }; The following patch fixes the regression by partially reverting the offending commit and can be backported to stable. Follow-up patches that popped up during review will be sent when net-next opens. They improve error reporting and add a "mdio" subtree binding to contain macb's MDIO-managed PHYs, similar to the binding in other drivers. This is v3. v2 started with Message-Id: <20180820121238.7779-1-a.fatoum@pengutronix.de>. without explicit marking as v2. v1 started with Message-Id: <20180814141240.9085-1-a.fatoum@pengutronix.de>. Changes introduced in v1 and v2 are noted in-line in their respective patches. Ahmad Fatoum (1): net: macb: Fix regression breaking non-MDIO fixed-link PHYs drivers/net/ethernet/cadence/macb_main.c | 27 +++++++++++++++--------- 1 file changed, 17 insertions(+), 10 deletions(-)