From patchwork Tue Jul 17 00:50:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Safonov X-Patchwork-Id: 944626 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=arista.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arista.com header.i=@arista.com header.b="HO87daZh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41V1sH6P41z9ryt for ; Tue, 17 Jul 2018 10:50:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729997AbeGQBUB (ORCPT ); Mon, 16 Jul 2018 21:20:01 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:40326 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729814AbeGQBUB (ORCPT ); Mon, 16 Jul 2018 21:20:01 -0400 Received: by mail-ed1-f65.google.com with SMTP id e19-v6so31312239edq.7 for ; Mon, 16 Jul 2018 17:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=from:to:cc:subject:date:message-id; bh=M1ylQ2h6nt5cB5CdLkcoQhEX7ylNyRSBzL+F5Mo/yeE=; b=HO87daZhGkKKK/Qdlf30//cpHln5xjbMSqflS/HxRp4ZlGug2btjOQTqV9+DltLwd8 Umg+ri9Gk4JAdAmdFox8Rn00VvEH4hn0EUUiUKTK+cdXOEOxzd8hoBVrnBDxuFN02dTt DjssaLFaOEEbn9f1gvidIteOcHjxNFg3PzjqgC01y8g8xaKZrbPaihc84yxs3flMpDlX pYbRxX/rWtS9MTwnbchhqaQhefq6YUuGAdenHS680WPEv+JRpphzvgPncbBLfKyvr7Yd lBHTtMEtCU/S5/XdoQL1CFrMkzVRKsu7T6JOS3jALE8OUykshQe0/32JjAh1dzXtw9vs lquQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=M1ylQ2h6nt5cB5CdLkcoQhEX7ylNyRSBzL+F5Mo/yeE=; b=ThUa5UdCe4DdsQH0IiQA9+nrQPnyWEdo61EYGYe50fzQ70w6qnFa1VKQ6gigKuEuxA tyaTz4g5wRI5Ejn4n29qYApnA86FtpoVPgBeLEwHobxPWtGt2vq1r9vDU/V91YYio7Wt Ef6f0TiPWOQyNLf8/VKKaQxaqkG5AVzqyfEiO4ulBM+uaN6t/MwN6s7PA0n8/aZZMV94 jjCavsI306QiObTdpJivnPmMUW7d+aIIKZ3UT3mXRRCB/SChZKjmZLlJJyEQs8EmKxA7 FjMFwni67/BsorR1bFvoiLPcmIqiGNoRlbIexMsqtVbswUj8zqHriqk+3pIau7X78whR UOjA== X-Gm-Message-State: AOUpUlExOk7cEVJN7wU8C37FokypSSYq1KvZQUlybtx8lqzcBieXSM0F bMfynSZ3DzTv5QM9GBLxRp2mmw== X-Google-Smtp-Source: AAOMgpcLX3sgyPVUFm7JiPQCcolFzw9OMBpEgiJmD3YDCDzxhojDwLoxBbmc7drYt7+XBOsmoXScyg== X-Received: by 2002:a50:8d12:: with SMTP id s18-v6mr14829469eds.238.1531788606313; Mon, 16 Jul 2018 17:50:06 -0700 (PDT) Received: from dhcp.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id z4-v6sm15063842edi.90.2018.07.16.17.50.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 17:50:05 -0700 (PDT) From: Dmitry Safonov To: linux-kernel@vger.kernel.org Cc: Dmitry Safonov , Ard Biesheuvel , "David S. Miller" , Herbert Xu , "H. Peter Anvin" , Ingo Molnar , John Stultz , "Kirill A. Shutemov" , Oleg Nesterov , Steffen Klassert , Stephen Boyd , Steven Rostedt , Thomas Gleixner , x86@kernel.org, linux-efi@vger.kernel.org, netdev@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com> Subject: [RFC 0/2] compat: in_compat_syscall() differs on x86 Date: Tue, 17 Jul 2018 01:50:02 +0100 Message-Id: <20180717005004.25984-1-dima@arista.com> X-Mailer: git-send-email 2.13.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Reading xfrm (ipsec) code I've found such code: : #ifdef CONFIG_COMPAT : if (in_compat_syscall()) : return -EOPNOTSUPP; : #endif While I can read that it's false on native i386, it's a bit misleading and in result it's better to introduce a helper for that. Grepping other code, I've found that there are already such helpers. And the uniq behavior of in_compat_syscall() on x86 is disturbing. Adjusting it to generic with the following.. Cc: Ard Biesheuvel Cc: "David S. Miller" Cc: Herbert Xu Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: John Stultz Cc: "Kirill A. Shutemov" Cc: Oleg Nesterov Cc: Steffen Klassert Cc: Stephen Boyd Cc: Steven Rostedt Cc: Thomas Gleixner Cc: x86@kernel.org Cc: linux-efi@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com> Dmitry Safonov (2): x86/compat: Adjust in_compat_syscall() to generic code under !COMPAT compat: Cleanup in_compat_syscall() callers arch/x86/include/asm/compat.h | 9 ++++++++- arch/x86/include/asm/ftrace.h | 4 +--- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/sys_x86_64.c | 11 ++++++----- arch/x86/mm/hugetlbpage.c | 4 ++-- arch/x86/mm/mmap.c | 2 +- drivers/firmware/efi/efivars.c | 16 ++++------------ include/linux/compat.h | 4 ++-- kernel/time/time.c | 2 +- net/xfrm/xfrm_state.c | 2 -- net/xfrm/xfrm_user.c | 2 -- 11 files changed, 27 insertions(+), 33 deletions(-)