mbox series

[V2,net-next,0/6] liquidio: enhanced ethtool --set-channels feature

Message ID 20180428063204.GA3229@felix-thinkpad.cavium.com
Headers show
Series liquidio: enhanced ethtool --set-channels feature | expand

Message

Manlunas, Felix April 28, 2018, 6:32 a.m. UTC 
From: Intiyaz Basha <intiyaz.basha@cavium.com>

For the ethtool --set-channels feature, the liquidio driver currently 
accepts max combined value as the queue count configured during driver
load time, where max combined count is the total count of input and output
queues. This limitation is applicable only when SR-IOV is enabled, that 
is, when VFs are created for PF. If SR-IOV is not enabled, the driver can
configure max supported (64) queues. 

This series of patches are for enhancing driver to accept 
max supported queues for ethtool --set-channels.

Changes in V2:
  Only patch #6 was changed to fix these Sparse warnings reported by kbuild
  test robot:
    lio_ethtool.c:848:5: warning: symbol 'lio_23xx_reconfigure_queue_count'
                         was not declared. Should it be static?
    lio_ethtool.c:877:22: warning: incorrect type in assignment (different
                          base types)
    lio_ethtool.c:878:22: warning: incorrect type in assignment (different
                          base types)
    lio_ethtool.c:879:22: warning: incorrect type in assignment (different
                          base types)

Intiyaz Basha (6):
  liquidio: Moved common function if_cfg_callback to lio_core.c
  liquidio: Moved common function list_delete_head to octeon_network.h
  liquidio: Moved common function delete_glists to lio_core.c
  liquidio: Moved common definition octnic_gather to octeon_network.h
  liquidio: Moved common function setup_glists to lio_core.c
  liquidio: enhanced ethtool --set-channels feature

 .../ethernet/cavium/liquidio/cn23xx_pf_device.c    |   6 +-
 .../ethernet/cavium/liquidio/cn23xx_pf_device.h    |   2 +
 drivers/net/ethernet/cavium/liquidio/lio_core.c    | 158 +++++++++++-
 drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 263 ++++++++++++++++++--
 drivers/net/ethernet/cavium/liquidio/lio_main.c    | 270 ++++-----------------
 drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 206 +---------------
 .../net/ethernet/cavium/liquidio/liquidio_common.h |   1 +
 .../net/ethernet/cavium/liquidio/octeon_device.c   |  12 +-
 .../net/ethernet/cavium/liquidio/octeon_device.h   |   2 +-
 .../net/ethernet/cavium/liquidio/octeon_network.h  |  60 ++++-
 10 files changed, 528 insertions(+), 452 deletions(-)

Comments

David Miller April 30, 2018, 1:26 p.m. UTC | #1 
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 27 Apr 2018 23:32:04 -0700

> From: Intiyaz Basha <intiyaz.basha@cavium.com>
> 
> For the ethtool --set-channels feature, the liquidio driver currently 
> accepts max combined value as the queue count configured during driver
> load time, where max combined count is the total count of input and output
> queues. This limitation is applicable only when SR-IOV is enabled, that 
> is, when VFs are created for PF. If SR-IOV is not enabled, the driver can
> configure max supported (64) queues. 
> 
> This series of patches are for enhancing driver to accept 
> max supported queues for ethtool --set-channels.
> 
> Changes in V2:
>   Only patch #6 was changed to fix these Sparse warnings reported by kbuild
>   test robot:
>     lio_ethtool.c:848:5: warning: symbol 'lio_23xx_reconfigure_queue_count'
>                          was not declared. Should it be static?
>     lio_ethtool.c:877:22: warning: incorrect type in assignment (different
>                           base types)
>     lio_ethtool.c:878:22: warning: incorrect type in assignment (different
>                           base types)
>     lio_ethtool.c:879:22: warning: incorrect type in assignment (different
>                           base types)

Series applied, thank you.