From patchwork Thu Apr 19 22:14:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Aring X-Patchwork-Id: 901539 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="IrSRh2uL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Rtb72LhWz9s3F for ; Fri, 20 Apr 2018 08:15:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753718AbeDSWPL (ORCPT ); Thu, 19 Apr 2018 18:15:11 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35714 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527AbeDSWPL (ORCPT ); Thu, 19 Apr 2018 18:15:11 -0400 Received: by mail-io0-f196.google.com with SMTP id d26-v6so8422125ioc.2 for ; Thu, 19 Apr 2018 15:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=lWXo6TdqiS692I+muN75uHPQK8W9vc3T2eV2aGOJPFc=; b=IrSRh2uLxtRwQE2txyQzUbgpBEtSpcfi1BLwA+r7HRieNNZGs05bSETCZX++v83ZEU a5kZgXvQFayjgn79CyYZxHectK5b6hx6RGkLZFfZ6ZUNoOvRWUf65DUhdEBD9Z6GxSxw BmWHBTC1F9w6KUD0t+ztnQG7eOk8R+HZcXU+/n30qVZ+K6FFlB/KS8O+V7UVpYKDAWMa S6lB3wOuQqo/1ncig4lUE1ZNXvgkHsmD6JESNmYQLV0EzNg3rHe76l7i7FYWVv5yZp4U MZQ7ojbveoU55PZB3S5S1fvQF6z4DbwuWXaWKLFuZS19cA1qjI1ywSlIWumXqufIImWv LuKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lWXo6TdqiS692I+muN75uHPQK8W9vc3T2eV2aGOJPFc=; b=n1lH5ITivvKayoWu00MArk7iKxu0aYPbi7ML2fz+XVuQWrk8bQbVWAdWte/BNRLu9L DIRe6oSNiyR6c+rthfC+4N1DtBr/A5QwdxJKT9hHN/2v3M9Fal29A5AkNCMy3dBUNpZs V5RNRS3Z9IlkmEBqfX5UCo7sLnZ7U4dvptO/pmV9hNyKNcye8eyt7Udy9XzgP1UYKMuE eP7/asWvkkF4hMndz7zRi/Dkb0De2MNTaUjZJasWE9F9GWLFxnwHirESGAUIcIMtYLws zZ3krxJf5Zyakp7Rh9h4yG4suL4+i7yjuxjSJkHf4rJnWrv+DN36oYNxWg73Vj6v4KM2 wETg== X-Gm-Message-State: ALQs6tC+5ZMepSqocUnHfcx24yNs3aY2XJd529cUCm1UyRiF0z+g6OF4 WSiLwzrP6Ci9zoGi5bc+2pbAMw== X-Google-Smtp-Source: AB8JxZojQjNeykFENVUVaCmBjBfRy5ZPCpeqmM7tlUpiKMSEnt/yJpww1hBkEHTs2Oo/tTiLr/BJuA== X-Received: by 2002:a6b:3889:: with SMTP id f131-v6mr7831491ioa.279.1524176110387; Thu, 19 Apr 2018 15:15:10 -0700 (PDT) Received: from x220t.lan ([64.26.149.125]) by smtp.gmail.com with ESMTPSA id z5-v6sm2287198ioe.58.2018.04.19.15.15.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 15:15:09 -0700 (PDT) From: Alexander Aring To: yotam.gi@gmail.com Cc: jhs@mojatatu.com, davem@davemloft.net, xiyou.wangcong@gmail.com, jiri@resnulli.us, yuvalm@mellanox.com, netdev@vger.kernel.org, kernel@mojatatu.com, Alexander Aring Subject: [PATCHv3 net 0/3] net: sched: ife: malformed ife packet fixes Date: Thu, 19 Apr 2018 18:14:42 -0400 Message-Id: <20180419221445.26205-1-aring@mojatatu.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As promised at netdev 2.2 tc workshop I am working on adding scapy support for tdc testing. It is still work in progress. I will submit the patches to tdc later (they are not in good shape yet). The good news is I have been able to find bugs which normal packet testing would not be able to find. With fuzzy testing I was able to craft certain malformed packets that IFE action was not able to deal with. This patch set fixes those bugs. changes since v3: - use pskb_may_pull changes since v2: - remove inline from __ife_tlv_meta_valid - add const to cast to meta_tlvhdr - add acked and reviewed tags Alexander Aring (3): net: sched: ife: signal not finding metaid net: sched: ife: handle malformed tlv length net: sched: ife: check on metadata length include/net/ife.h | 3 ++- net/ife/ife.c | 38 ++++++++++++++++++++++++++++++++++++-- net/sched/act_ife.c | 9 +++++++-- 3 files changed, 45 insertions(+), 5 deletions(-)