From patchwork Thu Apr 19 21:44:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Aring X-Patchwork-Id: 901523 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="toKqTa7l"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40RswZ4GBRz9s1t for ; Fri, 20 Apr 2018 07:45:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbeDSVpP (ORCPT ); Thu, 19 Apr 2018 17:45:15 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:38034 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753460AbeDSVpO (ORCPT ); Thu, 19 Apr 2018 17:45:14 -0400 Received: by mail-io0-f193.google.com with SMTP id h9-v6so8335707iob.5 for ; Thu, 19 Apr 2018 14:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=riOPabkFkxDZ1nZ5+LL4MTziF5TL1FEx2I3A8FXStHk=; b=toKqTa7lIYF7jUWYNJF4cp6M6v8XjUXzd06coX7aw3iPEm/Kvk43WgxoaiU4nhjwrk fNnJ19clNvqOrzbc1SMMWxslezzDd5cAQYfPmgY2FLYSrK2W+YC8MQqVlRVFMla0I27k VTyqG+97WeOeiSPhs7QrV/Z55LjxDp8KDHb9yZ12Uzpg/+rvjYo1D6AaY4qKZsdWAU5a jGHK24wRWKfPM8XXWUHmFtD9cJK0GEeuoJr+JUA8jIW7XnFGD0UKOsdRqr/juDos75Z1 +3FAtiQkUfygCTpP1PYRs/dJftJNdQQZNlU5sOH/9219j8ga0yNCiDnWFfwQgwV7Duxy nDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=riOPabkFkxDZ1nZ5+LL4MTziF5TL1FEx2I3A8FXStHk=; b=hyBZMazhH6Vhlutb2dmjElhm4N0Z62jwpxiYIB6Qs9zoLipq6iD4ZrktWds3Sv/zKI MmZJjNerAFp6aac79+hOQhATTpQFEg1oCzIbjSbW8xL46xFGzWxfD1ZB0yILpx52dM2d ZfoRtKb4A949Pi00K7hlfoA42WOmN7uw0+BDmqSYD+uRW1IRDc8cxd6PvjAUpb0QgW6f s9+ptvVwxdhu9wPZDWe4D4N7qs+08cfZT4rxLtnqg7zSbmdP51p2FdODwm4s90AZrO6S x270C6PjxmJs8iu47Nczcuw9ctQzY46Wbl/p7JoB93LN/AF8xgZytHAuKwtfZScuJjq4 z1Dg== X-Gm-Message-State: ALQs6tBMG546LubSZOsQpon8YqS/Sr6QitpGTKd+pgyDVvh3G0NgC5wJ vh0Z7fe/7Bk80UTROmtnZfshCN/6 X-Google-Smtp-Source: AB8JxZpZLR63bk3BT1rOZ7+OK+TdUgwtQqeDjxKmGBaqTuAKC5TEoZ3fjzWT80Ri32BBAKNEBfCKMw== X-Received: by 2002:a6b:a867:: with SMTP id r100-v6mr7929280ioe.143.1524174313524; Thu, 19 Apr 2018 14:45:13 -0700 (PDT) Received: from x220t.lan ([64.26.149.125]) by smtp.gmail.com with ESMTPSA id b66-v6sm45963itb.3.2018.04.19.14.45.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 14:45:12 -0700 (PDT) From: Alexander Aring To: yotam.gi@gmail.com Cc: jhs@mojatatu.com, davem@davemloft.net, xiyou.wangcong@gmail.com, jiri@resnulli.us, yuvalm@mellanox.com, netdev@vger.kernel.org, kernel@mojatatu.com, Alexander Aring Subject: [PATCHv2 net 0/3] net: sched: ife: malformed ife packet fixes Date: Thu, 19 Apr 2018 17:44:35 -0400 Message-Id: <20180419214438.6801-1-aring@mojatatu.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As promised at netdev 2.2 tc workshop I am working on adding scapy support for tdc testing. It is still work in progress. I will submit the patches to tdc later (they are not in good shape yet). The good news is I have been able to find bugs which normal packet testing would not be able to find. With fuzzy testing I was able to craft certain malformed packets that IFE action was not able to deal with. This patch set fixes those bugs. changes since v2: - remove inline from __ife_tlv_meta_valid - add const to cast to meta_tlvhdr - add acked and reviewed tags Alexander Aring (3): net: sched: ife: signal not finding metaid net: sched: ife: handle malformed tlv length net: sched: ife: check on metadata length include/net/ife.h | 3 ++- net/ife/ife.c | 38 ++++++++++++++++++++++++++++++++++++-- net/sched/act_ife.c | 9 +++++++-- 3 files changed, 45 insertions(+), 5 deletions(-)