From patchwork Mon Feb 5 20:09:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 869524 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zZzHb14ypz9sP1 for ; Tue, 6 Feb 2018 07:11:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbeBEUK3 (ORCPT ); Mon, 5 Feb 2018 15:10:29 -0500 Received: from sauhun.de ([88.99.104.3]:34216 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbeBEUKZ (ORCPT ); Mon, 5 Feb 2018 15:10:25 -0500 Received: from localhost (p54B337CF.dip0.t-ipconnect.de [84.179.55.207]) by pokefinder.org (Postfix) with ESMTPSA id 07B4D2C31F3; Mon, 5 Feb 2018 21:10:22 +0100 (CET) From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Dan Carpenter , linux-renesas-soc@vger.kernel.org, Wolfram Sang , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask Date: Mon, 5 Feb 2018 21:09:57 +0100 Message-Id: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In one Renesas driver, I found a typo which turned an intended bit shift ('<<') into a comparison ('<'). Because this is a subtle issue, I looked tree wide for similar patterns. This small patch series is the outcome. Buildbot and checkpatch are happy. Only compile-tested. To be applied individually per sub-system, I think. I'd think only the net: amd: patch needs to be conisdered for stable, but I leave this to people who actually know this driver. CCing Dan. Maybe he has an idea how to add a test to smatch? In my setup, only cppcheck reported a 'coding style' issue with a low prio. Wolfram Sang (4): v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO drm/exynos: fix comparison to bitshift when dealing with a mask v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing with a mask net: amd-xgbe: fix comparison to bitshift when dealing with a mask drivers/gpu/drm/exynos/regs-fimc.h | 2 +- drivers/media/dvb-frontends/stb0899_reg.h | 8 ++++---- drivers/media/platform/vsp1/vsp1_regs.h | 2 +- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)