From patchwork Fri Jan 26 09:12:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Poirier X-Patchwork-Id: 866216 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zSYBW3TXZz9s7F for ; Fri, 26 Jan 2018 20:14:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbeAZJM5 (ORCPT ); Fri, 26 Jan 2018 04:12:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:33539 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbeAZJMy (ORCPT ); Fri, 26 Jan 2018 04:12:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 359AFAE06; Fri, 26 Jan 2018 09:12:53 +0000 (UTC) From: Benjamin Poirier To: Jeff Kirsher Cc: Alexander Duyck , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] e1000e: Revert interrupt handling changes Date: Fri, 26 Jan 2018 18:12:33 +0900 Message-Id: <20180126091236.13044-1-bpoirier@suse.com> X-Mailer: git-send-email 2.15.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As discussed in the thread "[RFC PATCH] e1000e: Remove Other from EIAC.", https://www.spinics.net/lists/netdev/msg479311.html The following list of commits was considered: 4d432f67ff00 e1000e: Remove unreachable code (v4.5-rc1) 16ecba59bc33 e1000e: Do not read ICR in Other interrupt (v4.5-rc1) a61cfe4ffad7 e1000e: Do not write lsc to ics in msi-x mode (v4.5-rc1) 0a8047ac68e5 e1000e: Fix msi-x interrupt automask (v4.5-rc1) 19110cfbb34d e1000e: Separate signaling for link check/link up (v4.15-rc1) 4aea7a5c5e94 e1000e: Avoid receiver overrun interrupt bursts (v4.15-rc1) 4110e02eb45e e1000e: Fix e1000_check_for_copper_link_ich8lan return value. (v4.15-rc8) There have a been a slew of regressions due to unforeseen consequences (receive overflow triggers Other, vmware's emulated e1000e) and programming mistakes (4110e02eb45e). Since the e1000e driver is supposed to be in maintenance mode, this patch series revisits the above changes to prune them down. After this series, the remaining differences related to how interrupts were handled at commit 4d432f67ff00 ("e1000e: Remove unreachable code", v4.5-rc1) are: * the changes in commit 0a8047ac68e5 ("e1000e: Fix msi-x interrupt automask", v4.5-rc1) are preserved. * we manually clear Other from icr in e1000_msix_other(). We try to go back to a long lost time when things were simple and drivers ran smoothly. ---------------------------------------------------------------- Benjamin Poirier (3): Partial revert "e1000e: Avoid receiver overrun interrupt bursts" Revert "e1000e: Separate signaling for link check/link up" Revert "e1000e: Do not read ICR in Other interrupt" drivers/net/ethernet/intel/e1000e/defines.h | 1 - drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 ++------ drivers/net/ethernet/intel/e1000e/mac.c | 11 ++------ drivers/net/ethernet/intel/e1000e/netdev.c | 44 ++++++++++++++--------------- 4 files changed, 27 insertions(+), 40 deletions(-)