From patchwork Thu Jan 18 16:20:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Aring X-Patchwork-Id: 863002 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="ykXvM9EG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zMq2g6HTBz9s81 for ; Fri, 19 Jan 2018 03:21:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933460AbeARQVN (ORCPT ); Thu, 18 Jan 2018 11:21:13 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:46477 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932735AbeARQVL (ORCPT ); Thu, 18 Jan 2018 11:21:11 -0500 Received: by mail-io0-f174.google.com with SMTP id f34so20144825ioi.13 for ; Thu, 18 Jan 2018 08:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=HeahKfKCzrc4AGdEUglGcCces3nj0FYuhPR3YExSrrk=; b=ykXvM9EGYs6rqS3rAY1ZAnCfCkOyuPRngJGetrDBM6FYInPXuCUog88aIeiCyeLOv7 rzoqYzD3C7epSuVyan1WN70bqEyO3+8Et+58CPtHMQq5H0KfUkjsbJbkro/UK75LiW7B 19DubmyMuHw2rVmG8cbHFj2p85kJSj7ti/ty/cTKiuXGy4Sl7OHFRIE7XI6uJda1Su+i nLNoVb/kRaAm2bQagy4qROqNRd66QnhBwP9pQx6Z3tdORy+Et8dR+w6eRjuUEK38pUP3 pOJAcUzH+f8+PgBi1JxkHkUjpZTPmmJYaKQhHOCRk009nvUK4oIHtex7T/v9pSVh0urJ W5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HeahKfKCzrc4AGdEUglGcCces3nj0FYuhPR3YExSrrk=; b=GtcyS76RBCajMpFaOlnz7U+bCYHg7mWV7aa0W1IpOu7dILdlKJw3snwVWsmjXI5uU1 Ov0JeKUaqGeCLCkP92/bqDXshBJaqyemUhjvd7V2o8WYqU3kee9UxHawm71+CiJ+ZHwj L9cXp9mRRKFaUuxiZSp/EBoZzYMdiuXnSacOpesKRkp01OTUbaXwECEX0YE2GYFF0ZVE agyAlHE7PFd7mZNGeTRtBVFZQ/m7PWMmA6VRw8ZR9HQPEl8iDl1Jv+QHcgiPXcTXLjiT zRnlJe1aGCzh2pFlJefQq7nCcFet7WkdD7thhOP2H2lCf5zc3mLu+9btyjT8LKdPowlW NhZw== X-Gm-Message-State: AKwxyteGLpTphfIhkiquvBDa5bW7LdSsWp/cZ/660LsBN9eEgpd9S8VZ I9MOkKV8qiXhspf98M2StSXQBg== X-Google-Smtp-Source: AH8x226OrdgGm1agS3kurci90I4zOdB+0H9e7HCFZ3pn5x6TVEXgdFmKN9oI191D3GW8rAn8cJqXGw== X-Received: by 10.107.104.17 with SMTP id d17mr480063ioc.138.1516292470759; Thu, 18 Jan 2018 08:21:10 -0800 (PST) Received: from x220t.lan ([64.26.149.125]) by smtp.gmail.com with ESMTPSA id k185sm3831890iok.39.2018.01.18.08.21.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 08:21:10 -0800 (PST) From: Alexander Aring To: jhs@mojatatu.com Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, kubakici@wp.pl, Alexander Aring , David Ahern Subject: [PATCHv3 net-next 0/7] net: sched: cls: add extack support Date: Thu, 18 Jan 2018 11:20:48 -0500 Message-Id: <20180118162055.31587-1-aring@mojatatu.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, this patch adds extack support for TC classifier subsystem. The first patch fixes some code style issues for this patch series pointed out by checkpatch. The other patches until the last one prepares extack handling for the TC classifier subsystem and handle generic extack errors. The last patch is an example for u32 classifier to add extack support inside the callbacks delete and change. There exists a init callback as well, but most classifier implementation run a kalloc() once to allocate something. Not necessary _yet_ to add extack support now. - Alex Cc: David Ahern changes since v3: - fix accidentally move of config option mismatch message in PATCH 2/8 correct one is 4/8, detected by kbuildbot (Thank you) - Removed patch "net: sched: cls: add extack support for tc_setup_cb_call" PATCH 7/8 in version v2 as suggested by Jakub Kicinski (Thank you) - changed NL_SET_ERR_MSG to NL_SET_ERR_MSG_MOD as suggested by Jakub Kicinski in u32 cls (Thank You) - Removed text from cover letter that I was waiting for Jiri's Patches as detected by Jamal Hadi Salim (Thank you). changes since v2: - rebased on Jiri's patches (Thank you) - several spelling fixes pointed out by Cong Wang (Thank you) - several spelling fixes pointed out by David Ahern (Thank you) - use David Ahern recommendation if config option is mismatch, but combine it with Cong Wang recommendation to put config name into it (Thank you) Alexander Aring (7): net: sched: cls: fix code style issues net: sched: cls_api: handle generic cls errors net: sched: cls: add extack support for change callback net: sched: cls: add extack support for tcf_exts_validate net: sched: cls: add extack support for delete callback net: sched: cls: add extack support for tcf_change_indev net: sched: cls_u32: add extack support include/net/pkt_cls.h | 10 +++++-- include/net/sch_generic.h | 7 +++-- net/sched/cls_api.c | 64 +++++++++++++++++++++++++++++---------- net/sched/cls_basic.c | 14 +++++---- net/sched/cls_bpf.c | 13 ++++---- net/sched/cls_cgroup.c | 9 ++++-- net/sched/cls_flow.c | 8 +++-- net/sched/cls_flower.c | 20 ++++++++----- net/sched/cls_fw.c | 17 ++++++----- net/sched/cls_matchall.c | 15 ++++++---- net/sched/cls_route.c | 12 ++++---- net/sched/cls_rsvp.h | 7 +++-- net/sched/cls_tcindex.c | 14 +++++---- net/sched/cls_u32.c | 76 ++++++++++++++++++++++++++++++++++------------- 14 files changed, 194 insertions(+), 92 deletions(-)