From patchwork Sun Nov 12 23:15:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 837297 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="JCr9xasg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yZqRg3d7wz9s7m for ; Mon, 13 Nov 2017 10:17:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbdKLXPZ (ORCPT ); Sun, 12 Nov 2017 18:15:25 -0500 Received: from mail-wr0-f177.google.com ([209.85.128.177]:54840 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdKLXPX (ORCPT ); Sun, 12 Nov 2017 18:15:23 -0500 Received: by mail-wr0-f177.google.com with SMTP id l22so12889613wrc.11 for ; Sun, 12 Nov 2017 15:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=XGEng5Fo6DAXtZ6g4DTT72B0+cMdR8IP468QYpoifbM=; b=JCr9xasgnCjQTbE24jJ0NcVoOGujYVmQzICsytg8glN6yesWwE68QoVyTT/3pzrIAY LUuraOU1OdwgSq1419QUqaj2VBNnLJhT9R0A5QIo9YK1KJXmcPSo3MG5FFFl6brcCgEv Ezn7jRn1+VRCWuqGHiWQOvBRWVMM0roTOTBkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XGEng5Fo6DAXtZ6g4DTT72B0+cMdR8IP468QYpoifbM=; b=FkvGxJGOIi4hxPgVXvumwNPih1wCtln4d1rLqZ3O2phcQj06lnFk8IVyygS6rCJulO 6PeaoRV97/pnTGbDiwALX7VJ/KYYi5eS4kj5NesUbaH4T9xdK2KUfu+Ag8kHautO2of8 nDZLB/CFuduY1+Mk2niv8iD0nHqi0Lz0VHxMooEevTslkPLDV2XxWdEb47v9AoFqjvsc shiW7Z2lb+Kih3h9eE2kYWtCDBPfkIq4d7D0DhUWGcn5RreMS7iJNh2YqQwcuKK7qd6t fCeWTNPqX7SBZnvAP85HT5xI/a9BM1uyhJovKFj12wPaBaOS+uNHNMnz49wKITjYtXhT djLg== X-Gm-Message-State: AJaThX5ZSlmP5Z2QcgxFXKGnU8A/wb6ro7NS0RdZVM1XfU6gcXiARlRV VIvu4X6y9Azeu9lkGMgxKIHbyZ6/ X-Google-Smtp-Source: AGs4zMbFfGKly6Jg5NcoVABQoUXjxFMFuhIiK9wP4zmHnKQFvbFhAnPGlX+2ImWgmml1SQSzWh/oTw== X-Received: by 10.223.135.132 with SMTP id b4mr5902331wrb.248.1510528522352; Sun, 12 Nov 2017 15:15:22 -0800 (PST) Received: from wildmoose.dk ([2a01:488:66:1000:57e6:57d1:0:1]) by smtp.gmail.com with ESMTPSA id o70sm48012169wrb.62.2017.11.12.15.15.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Nov 2017 15:15:21 -0800 (PST) From: Rasmus Villemoes To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 0/7] net: core: devname allocation cleanups Date: Mon, 13 Nov 2017 00:15:03 +0100 Message-Id: <20171112231511.4666-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It's somewhat confusing to have both dev_alloc_name and dev_get_valid_name. I can't see why the former is less strict than the latter, so make them (or rather dev_alloc_name_ns and dev_get_valid_name) equivalent, hardening dev_alloc_name() a little. Obvious follow-up patches would be to only export one function, and make dev_alloc_name a static inline wrapper for that (whichever name is chosen for the exported interface). But maybe there is a good reason the two exported interfaces do different checking, so I'll refrain from including the trivial but tree-wide renaming in this series. Rasmus Villemoes (7): net: core: improve sanity checking in __dev_alloc_name net: core: move dev_alloc_name_ns a little higher net: core: eliminate dev_alloc_name{,_ns} code duplication net: core: drop pointless check in __dev_alloc_name net: core: check dev_valid_name in __dev_alloc_name net: core: maybe return -EEXIST in __dev_alloc_name net: core: dev_get_valid_name is now the same as dev_alloc_name_ns net/core/dev.c | 62 +++++++++++++++++++++------------------------------------- 1 file changed, 22 insertions(+), 40 deletions(-)