Message ID | 1562657451-20819-1-git-send-email-paulb@mellanox.com |
---|---|
Headers | show |
Series | net/sched: Introduce tc connection tracking | expand |
From: Paul Blakey <paulb@mellanox.com> Date: Tue, 9 Jul 2019 10:30:47 +0300 > This patch series add connection tracking capabilities in tc sw datapath. > It does so via a new tc action, called act_ct, and new tc flower classifier matching > on conntrack state, mark and label. ... Ok, I applied this, but two things: 1) You owe Cong Wang an explanation, a real detailed one, about the L2 vs L3 design of this feature. I did not see you address his feedback, but if you did I apologize. 2) Because the MPLS changes went in first, TCA_ID_CT ended up in a different spot in the enumeration and therefore the value is different. Thanks.
On 7/9/2019 10:14 PM, David Miller wrote: > From: Paul Blakey <paulb@mellanox.com> > Date: Tue, 9 Jul 2019 10:30:47 +0300 > >> This patch series add connection tracking capabilities in tc sw datapath. >> It does so via a new tc action, called act_ct, and new tc flower classifier matching >> on conntrack state, mark and label. > ... > > Ok, I applied this, but two things: > > 1) You owe Cong Wang an explanation, a real detailed one, about the L2 > vs L3 design of this feature. I did not see you address his feedback, > but if you did I apologize. > > 2) Because the MPLS changes went in first, TCA_ID_CT ended up in a > different spot in the enumeration and therefore the value is > different. > > Thanks. Thanks! Re 1, I provided one in "Re: [PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking", hope that's enough.