From patchwork Fri Apr 19 22:36:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Herbert X-Patchwork-Id: 1088242 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=herbertland.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=herbertland-com.20150623.gappssmtp.com header.i=@herbertland-com.20150623.gappssmtp.com header.b="BydYbyGv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44m9p20sw8z9s6w for ; Sat, 20 Apr 2019 08:37:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbfDSWhM (ORCPT ); Fri, 19 Apr 2019 18:37:12 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:46097 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbfDSWhM (ORCPT ); Fri, 19 Apr 2019 18:37:12 -0400 Received: by mail-pl1-f195.google.com with SMTP id o7so901690pll.13 for ; Fri, 19 Apr 2019 15:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=herbertland-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=7MITzdKyDh8jJ4OM/ZOYoFc3ffH7cJ+VJbO59BpppSE=; b=BydYbyGvWz1Rv5k4ZBDfEbIcMlopXX2yB1p612P6ILbt6yoNOeo2jPWLG3W866sgjD OBYoNV4pyv/Obfrx5uYOa6F4fV4SOQZ3K2LG79uCbxh3nfolCD2LLCX+Oq7c6Fe4JRiQ elP4rW9Zs/Sz0jUdxWZ/huEufNxhIjvCKW2v9/JwIj4dQuwoJ5DyxBUjBGFsEckPTMfC XUJA3WEzEnZ85cNXY537Od0qW9+GPY0qEf2RdA0IE6ZBAbB6d040lzODT8Vm6LC9VhJT fZ9Ge7hobLKvXI9+pUvWpUqXV5EUKEDGDXUVKmQA3h0f6YO6/D7fVu3g2D1ue7u9Vqrx 5POQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7MITzdKyDh8jJ4OM/ZOYoFc3ffH7cJ+VJbO59BpppSE=; b=ClWrtpHQvRMDuoLxzpDoARELInc3HTLkYqXPITzEKF5b1d/sE0MxoBHa3Xh3xIYU7P 4ROQBepG6DAS2ckD7CIBzK/r9Jr/tN/0vtni3M3leBfL8JPUpZGdExJvbtC0nsieAZPD tsBm8q7l8FOfY9fR9L0DeG3yguMCsRiE5Niqfyu76Ksdloc9bZtpqOMG5byTxQt/t43p dJCG6vGREpct4uK4kZB+WLsyXVzQzisu4SSa6KNcqHPJtRt+wqDRyZCRqTfrSJjZhE2X ghqSYYaY8EsahfZFy9hIgu/kW7myukORMR8bL7cVerxyGcQvVFxrqo5+KlYM0lv3jC2u r/ow== X-Gm-Message-State: APjAAAVn8ZZZqlwT1uZvRBi8IfPQl0zJphGplVdQePMXbYi9xDn46MIK AArsjF2gG0i+TBwd6SGzHIGZJ5b1mOE= X-Google-Smtp-Source: APXvYqxO6SKKM9UTe00YlKhdLkGkdKDiqGrk9h9aCOBiG7POIKA1XzF2Qz8vThBHs5oQv9FOzjRfvA== X-Received: by 2002:a17:902:e209:: with SMTP id ce9mr3810093plb.29.1555713430920; Fri, 19 Apr 2019 15:37:10 -0700 (PDT) Received: from localhost.localdomain (c-73-223-249-119.hsd1.ca.comcast.net. [73.223.249.119]) by smtp.gmail.com with ESMTPSA id u5sm8548277pfm.121.2019.04.19.15.37.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Apr 2019 15:37:10 -0700 (PDT) From: Tom Herbert X-Google-Original-From: Tom Herbert To: davem@davemloft.net, netdev@vger.kernel.org Cc: Tom Herbert Subject: [PATCH v5 net-next 0/6] exthdrs: Make ext. headers & options useful - Part I Date: Fri, 19 Apr 2019 15:36:50 -0700 Message-Id: <1555713416-12209-1-git-send-email-tom@quantonium.net> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Extension headers are the mechanism of extensibility for the IPv6 protocol, however to date they have only seen limited deployment. The reasons for that are because intermediate devices don't handle them well, and there haven't really be any useful extension headers defined. In particular, Destination and Hop-by-Hop options have not been deployed to any extent. The landscape may be changing as there are now a number of serious efforts to define and deploy extension headers. In particular, a number of uses for Hop-by-Hop Options are currently being proposed, Some of these are from router vendors so there is hope that they might start start to fix their brokenness. These proposals include IOAM, Path MTU, Firewall and Service Tickets, SRv6, CRH, etc. Assuming that IPv6 extension headers gain traction, that leaves a noticeable gap in IPv4 support. IPv4 options have long been considered a non-starter for deployment. An alternative being proposed is to enable use of IPv6 options with IPv4 (draft-herbert-ipv4-eh-00). This series of patch sets endeavours to make extension headers and related options useful and easy to use. The following items will be addressed: - Reorganize extension header files - Allow registration of TLV handlers - Elaborate on the TLV tables to include more characteristics - Add a netlink interface to set TLV parameters (such as alignment requirements, authorization to send, etc.) - Enhance validation of TLVs being sent. Validation is strict (unless overridden by admin) following that sending clause of the robustness principle - Allow non-privileged users to set Hop-by-Hop and Destination Options if authorized by the admin - Add an API that allows individual Hop-by-Hop and Destination Options to be set or removed for a connected socket. The backend end enforces permissions on what TLVs may be set and merges set TLVs per following the rules in the TLV parameter table (for instance, TLV parameters include a preferred sending order that merging adheres to) - Add an infrastructure to allow Hop-by-Hop and Destination Options to be processed in the context of a connected socket - Support for some of the aforementioned options - Enable IPv4 extension headers ------ In this series: - Create exhdrs_options.c. Move options specific processing to this file from exthdrs.c (for RA, Jumbo, Calipso, and HAO) - Move generic functions exthdrs_core.c. - Allow modules to register TLV handlers for Destination and HBH options. - Add parameters block to TLV type entries that describe characteristics related to the TLV. For the most part, these encode rules about sending each TLV (TLV alignment requirements for instance). - Add a netlink interface to manage parameters in the TLV table. - Add validation of HBH and Destination Options that are set on a socket or in ancillary data in sendmsg. The validation applies the rules that are encoded in the TLV parameters. - TLV parameters includes permissions that may allow non-privileged users to set specific TLVs on a socket HBH options or Destination options. Strong validation can be enabled for this to constrain what the non-privileged user is able to do. v2: - Don't rename extension header files with IPv6 specific code before code for IPv4 extension headers is present - Added patches for creating TLV parameters and validation v3: - Fix kbuild errors. Ensure build and operation when IPv6 is disabled. v4: - Remove patch that consolidated option cases in option cases in ip6_datagram_send_ctl per feedback v5: - Add signoffs. Tested: Set Hop-by-Hop options on TCP/UDP socket and verified to be functional. Tom Herbert (6): exthdrs: Create exthdrs_options.c exthdrs: Move generic EH functions to exthdrs_core.c exthdrs: Registration of TLV handlers and parameters exthdrs: Add TX parameters ip6tlvs: Add netlink interface ip6tlvs: Validation of TX Destination and Hop-by-Hop options include/net/ipv6.h | 127 ++++++ include/uapi/linux/in6.h | 49 ++ net/ipv6/Makefile | 2 +- net/ipv6/datagram.c | 51 ++- net/ipv6/exthdrs.c | 388 ++-------------- net/ipv6/exthdrs_core.c | 1091 ++++++++++++++++++++++++++++++++++++++++++++ net/ipv6/exthdrs_options.c | 347 ++++++++++++++ net/ipv6/ipv6_sockglue.c | 43 +- 8 files changed, 1694 insertions(+), 404 deletions(-) create mode 100644 net/ipv6/exthdrs_options.c