| Message ID | 155508321298.11035.7196100250886302901.stgit@warthog.procyon.org.uk |
|---|---|
| Headers | show |
| Series | rxrpc: Fixes | expand |
From: David Howells <dhowells@redhat.com> Date: Fri, 12 Apr 2019 16:33:33 +0100 > Here is a collection of fixes for rxrpc: > > (1) rxrpc_error_report() needs to call sock_error() to clear the error > code from the UDP transport socket, lest it be unexpectedly revisited > on the next kernel_sendmsg() call. This has been causing all sorts of > weird effects in AFS as the effects have typically been felt by the > wrong RxRPC call. > > (2) Allow a kernel user of AF_RXRPC to easily detect if an rxrpc call has > completed. > > (3) Allow errors incurred by attempting to transmit data through the UDP > socket to get back up the stack to AFS. > > (4) Make AFS use (2) to abort the synchronous-mode call waiting loop if > the rxrpc-level call completed. > > (5) Add a missing tracepoint case for tracing abort reception. > > (6) Fix detection and handling of out-of-order ACKs. > > For the patch series: > > Tested-by: Jonathan Billings <jsbillin@umich.edu> Series applied, thanks.
Here is a collection of fixes for rxrpc: (1) rxrpc_error_report() needs to call sock_error() to clear the error code from the UDP transport socket, lest it be unexpectedly revisited on the next kernel_sendmsg() call. This has been causing all sorts of weird effects in AFS as the effects have typically been felt by the wrong RxRPC call. (2) Allow a kernel user of AF_RXRPC to easily detect if an rxrpc call has completed. (3) Allow errors incurred by attempting to transmit data through the UDP socket to get back up the stack to AFS. (4) Make AFS use (2) to abort the synchronous-mode call waiting loop if the rxrpc-level call completed. (5) Add a missing tracepoint case for tracing abort reception. (6) Fix detection and handling of out-of-order ACKs. For the patch series: Tested-by: Jonathan Billings <jsbillin@umich.edu> The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20190412 and can also be found on the following branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (1): rxrpc: Trace received connection aborts Jeffrey Altman (1): rxrpc: Fix detection of out of order acks Marc Dionne (4): rxrpc: Clear socket error rxrpc: Make rxrpc_kernel_check_life() indicate if call completed rxrpc: Allow errors to be returned from rxrpc_queue_packet() afs: Check for rxrpc call completion in wait loop Documentation/networking/rxrpc.txt | 16 +++++++++------- fs/afs/rxrpc.c | 24 +++++++++++++++++------- include/net/af_rxrpc.h | 4 +++- net/rxrpc/af_rxrpc.c | 14 +++++++++----- net/rxrpc/ar-internal.h | 1 + net/rxrpc/conn_event.c | 11 +++++++---- net/rxrpc/input.c | 18 ++++++++++++------ net/rxrpc/peer_event.c | 5 +++++ net/rxrpc/sendmsg.c | 21 ++++++++++++--------- 9 files changed, 75 insertions(+), 39 deletions(-)