mbox series

[net-next,0/5] Some cleanup and bugfix for desc filling

Message ID 1539691132-158455-1-git-send-email-linyunsheng@huawei.com
Headers show
Series Some cleanup and bugfix for desc filling | expand

Message

Yunsheng Lin Oct. 16, 2018, 11:58 a.m. UTC 
When retransmiting packets, skb_cow_head which is called in
hns3_set_tso may clone a new header. And driver will clear the
checksum of the header after doing DMA map, so HW will read the
old header whose L3 checksum is not cleared and calculate a
wrong L3 checksum.

Also When sending a big fragment using multiple buffer descriptor,
hns3 does one maping, but do multiple unmapping when tx is done,
which may cause unmapping problem.

This patchset does some cleanup before fixing the above problem.

Fuyun Liang (3):
  net: hns3: add handling for big TX fragment
  net: hns3: rename hns_nic_dma_unmap
  net: hns3: fix for multiple unmapping DMA problem

Peng Li (2):
  net: hns3: remove hns3_fill_desc_tso
  net: hns3: move DMA map into hns3_fill_desc

 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 137 +++++++++++-------------
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.h |   3 +-
 2 files changed, 62 insertions(+), 78 deletions(-)

Comments

David Miller Oct. 16, 2018, 5:10 p.m. UTC | #1 
From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Tue, 16 Oct 2018 19:58:47 +0800

> When retransmiting packets, skb_cow_head which is called in
> hns3_set_tso may clone a new header. And driver will clear the
> checksum of the header after doing DMA map, so HW will read the
> old header whose L3 checksum is not cleared and calculate a
> wrong L3 checksum.
> 
> Also When sending a big fragment using multiple buffer descriptor,
> hns3 does one maping, but do multiple unmapping when tx is done,
> which may cause unmapping problem.
> 
> This patchset does some cleanup before fixing the above problem.

Series applied.