mbox series

[v3,net-next,0/5] replace tcp_set_state tracepoint with inet_sock_set_state

Message ID 1513739574-3345-1-git-send-email-laoar.shao@gmail.com
Headers show
Series replace tcp_set_state tracepoint with inet_sock_set_state | expand

Message

Yafang Shao Dec. 20, 2017, 3:12 a.m. UTC
According to the discussion in the mail thread
https://patchwork.kernel.org/patch/10099243/,
tcp_set_state tracepoint is renamed to inet_sock_set_state tracepoint and is
moved to include/trace/events/sock.h.

With this new tracepoint, we can trace AF_INET/AF_INET6 sock state transitions.
As there's only one single tracepoint for inet, so I didn't create a new trace
file named trace/events/inet_sock.h, and just place it in
include/trace/events/sock.h

Currently TCP/DCCP/SCTP state transitions are traced with this tracepoint.

- Why not more protocol ?
If we really think that anonter protocol should be traced, I will modify the
code to trace it.
I just want to make the code easy and not output useless information.

Steven Rostedt (VMware) (1):
  tcp: Export to userspace the TCP state names for the trace events

Yafang Shao (4):
  net: tracepoint: replace tcp_set_state tracepoint with
    inet_sock_set_state tracepoint
  net: sock: replace sk_state_load with inet_sk_state_load and remove
     sk_state_store
  net: tracepoint: using sock_set_state tracepoint to trace DCCP state
    transition
  net: tracepoint: using sock_set_state tracepoint to trace SCTP state
    transition

 include/net/inet_sock.h         |  25 ++++++++++
 include/net/sock.h              |  25 ----------
 include/trace/events/sock.h     | 107 ++++++++++++++++++++++++++++++++++++++++
 include/trace/events/tcp.h      |  16 ------
 net/dccp/proto.c                |   2 +-
 net/ipv4/af_inet.c              |  14 ++++++
 net/ipv4/inet_connection_sock.c |   8 +--
 net/ipv4/inet_hashtables.c      |   2 +-
 net/ipv4/tcp.c                  |  10 ++--
 net/ipv4/tcp_diag.c             |   2 +-
 net/ipv4/tcp_ipv4.c             |   2 +-
 net/ipv6/tcp_ipv6.c             |   2 +-
 net/sctp/endpointola.c          |   2 +-
 net/sctp/sm_sideeffect.c        |   4 +-
 net/sctp/socket.c               |  12 ++---
 15 files changed, 167 insertions(+), 66 deletions(-)

--
1.8.3.1

Comments

David Miller Dec. 20, 2017, 7 p.m. UTC | #1
From: Yafang Shao <laoar.shao@gmail.com>
Date: Wed, 20 Dec 2017 11:12:49 +0800

> According to the discussion in the mail thread
> https://patchwork.kernel.org/patch/10099243/,
> tcp_set_state tracepoint is renamed to inet_sock_set_state tracepoint and is
> moved to include/trace/events/sock.h.
> 
> With this new tracepoint, we can trace AF_INET/AF_INET6 sock state transitions.
> As there's only one single tracepoint for inet, so I didn't create a new trace
> file named trace/events/inet_sock.h, and just place it in
> include/trace/events/sock.h
> 
> Currently TCP/DCCP/SCTP state transitions are traced with this tracepoint.
> 
> - Why not more protocol ?
> If we really think that anonter protocol should be traced, I will modify the
> code to trace it.
> I just want to make the code easy and not output useless information.

Series applied, thanks.