| Message ID | TYAPR01MB6044F6C94C3BEFC65801A849D93B2@TYAPR01MB6044.jpnprd01.prod.outlook.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] input_helper: Modify the check range of the input event number | expand |
Hi! The patch looks good, however ti does not apply for a several reasons. > The following commit was set to 1023 for the upper limit of event IDs, so we changed it to check up to 0-1023. > https://github.com/torvalds/linux/commit/7f8d4cad1e4e11a45d02bd6e024cc2812963c38a > > --- > Changes in v2: > - Changed it to check up to 0-1023. > --- > --- These sequencies of --- actually corrupt the patch, since --- has a special meaning, it divides the description from the actual changes in code. But even when I remove this part of the patch it does not apply because the patch itself was corrupted by your email client, the tabs \t were replaced with spaces. See: https://www.kernel.org/doc/html/next/process/email-clients.html > If the input event number is greater than 32, the newly added event ID > will be 256 or later. > When there were already 32 input events in the device, this test program > only checked 0~99, so it failed because it could not find a new input > event ID. > > In order to eliminate this failure, we changed the event ID range to be > checked by this test program to 0~1023. You are missing signed-off-by line here, see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#developer-s-certificate-of-origin-1-1 > --- > > diff --git a/testcases/kernel/input/input_helper.c b/testcases/kernel/input/input_helper.c > index 09530fb..6b60d17 100644 > --- a/testcases/kernel/input/input_helper.c > +++ b/testcases/kernel/input/input_helper.c > @@ -40,7 +40,7 @@ > int ret, fd = -1; > unsigned int i; > > - for (i = 0; i < 100; i++) { > + for (i = 0; i < 1024; i++) { > snprintf(path, sizeof(path), "/dev/input/event%i", i); > > fd = open(path, O_RDONLY); > > > > --- > Akihisa Kogure > akihisa.kogure.ke@kyocera.jp > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp
diff --git a/testcases/kernel/input/input_helper.c b/testcases/kernel/input/input_helper.c index 09530fb..6b60d17 100644 --- a/testcases/kernel/input/input_helper.c +++ b/testcases/kernel/input/input_helper.c @@ -40,7 +40,7 @@ int ret, fd = -1; unsigned int i; - for (i = 0; i < 100; i++) { + for (i = 0; i < 1024; i++) { snprintf(path, sizeof(path), "/dev/input/event%i", i); fd = open(path, O_RDONLY);