| Message ID | 20240829065933.21902-1-wegao@suse.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v3] isofs.sh: Create group and user before check mount option | expand |
Hi Wei, Cyril, > Case will failed if default system has no group named "bin", such > as suse sle-micro, so this patch will create specific group for test > instead of fixed "bin" group. I suggested an alternative solution, which does not force user creation on all distros. https://patchwork.ozlabs.org/project/ltp/patch/20240830113913.49675-1-pvorel@suse.cz/ I proposed (long term) library solution: https://github.com/linux-test-project/ltp/issues/468#issuecomment-2320992135 Kind regards, Petr
diff --git a/testcases/kernel/fs/iso9660/isofs.sh b/testcases/kernel/fs/iso9660/isofs.sh index d1a362d97..9114c1d99 100755 --- a/testcases/kernel/fs/iso9660/isofs.sh +++ b/testcases/kernel/fs/iso9660/isofs.sh @@ -13,10 +13,27 @@ TST_NEEDS_CMDS="mount umount" TST_NEEDS_TMPDIR=1 TST_TESTFUNC=do_test TST_CNT=3 +TST_SETUP="setup" +TST_CLEANUP="cleanup" MAX_DEPTH=3 MAX_DIRS=4 +test_group="ltp_isofs" + +setup() +{ + if ! getent group $test_group > /dev/null; then + ROD useradd -U $test_group + fi +} + +cleanup() +{ + ROD userdel -f $test_group + ROD groupdel -f $test_group +} + gen_fs_tree() { local cur_path="$1" @@ -92,8 +109,8 @@ do_test() "loop,block=512,unhide" \ "loop,block=1024,cruft" \ "loop,block=2048,nocompress" \ - "loop,check=strict,map=off,gid=bin,uid=bin" \ - "loop,check=strict,map=acorn,gid=bin,uid=bin" \ + "loop,block=2048,nocompress" \ "loop,check=strict,map=off,gid=$test_group,uid=$test_group" \ + "loop,check=strict,map=acorn,gid=$test_group,uid=$test_group" \ "loop,check=relaxed,map=normal" \ "loop,block=512,unhide,session=2" do
Case will failed if default system has no group named "bin", such as suse sle-micro, so this patch will create specific group for test instead of fixed "bin" group. Signed-off-by: Wei Gao <wegao@suse.com> --- testcases/kernel/fs/iso9660/isofs.sh | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)