| Message ID | 20240814-landlock_remove_doc_stats-v1-1-b5821d0bb3de@suse.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [RESEND] Remove landlock from coverage stats | expand |
Hi Andrea, > Following syscalls can be removed from the documentation coverage > statistics since we they are tested inside landlock testing suite: > - landlock_create_ruleset > - landlock_add_rule > - landlock_restrict_self Reviewed-by: Petr Vorel <pvorel@suse.cz> Thanks! BTW for these stats, how about generating them on fly? Take list from glibc sysdeps/unix/sysv/linux/syscall-names.list [1] and git grep source code? Or do we want to add them manually to make sure we add only syscalls which are really tested? BTW this list could be also used for include/lapi/syscall/ generation (Cyril asked for some automatic approach). Kind regards, Petr [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/syscall-names.list;h=7871f93b94d731d26928a3e12e4ca8b88606aad5;hb=2be0572f3a41d5d5a8bb3b2b04244b7c01ac0f58 > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > --- > doc/conf.py | 3 +++ > 1 file changed, 3 insertions(+) > diff --git a/doc/conf.py b/doc/conf.py > index ac1220450..425f72257 100644 > --- a/doc/conf.py > +++ b/doc/conf.py > @@ -88,6 +88,9 @@ def generate_syscalls_stats(_): > 'getpmsg', > 'putmsg', > 'putpmsg', > + 'landlock_create_ruleset', > + 'landlock_add_rule', > + 'landlock_restrict_self', > ] > # populate with not implemented, reserved, unmaintained syscalls defined
Hi, On 8/14/24 11:28, Petr Vorel wrote: > Hi Andrea, > >> Following syscalls can be removed from the documentation coverage >> statistics since we they are tested inside landlock testing suite: >> - landlock_create_ruleset >> - landlock_add_rule >> - landlock_restrict_self > Reviewed-by: Petr Vorel <pvorel@suse.cz> > > Thanks! > > BTW for these stats, how about generating them on fly? > > Take list from glibc sysdeps/unix/sysv/linux/syscall-names.list [1] > and git grep source code? Or do we want to add them manually to make sure we add > only syscalls which are really tested? > > BTW this list could be also used for include/lapi/syscall/ generation > (Cyril asked for some automatic approach). I started to work on it, but I didn't find time yet. When I merge all tests for increase LTP coverage I will work on it. > > Kind regards, > Petr > > [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/syscall-names.list;h=7871f93b94d731d26928a3e12e4ca8b88606aad5;hb=2be0572f3a41d5d5a8bb3b2b04244b7c01ac0f58 > >> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> >> --- >> doc/conf.py | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/doc/conf.py b/doc/conf.py >> index ac1220450..425f72257 100644 >> --- a/doc/conf.py >> +++ b/doc/conf.py >> @@ -88,6 +88,9 @@ def generate_syscalls_stats(_): >> 'getpmsg', >> 'putmsg', >> 'putpmsg', >> + 'landlock_create_ruleset', >> + 'landlock_add_rule', >> + 'landlock_restrict_self', >> ] >> # populate with not implemented, reserved, unmaintained syscalls defined Andrea
diff --git a/doc/conf.py b/doc/conf.py index ac1220450..425f72257 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -88,6 +88,9 @@ def generate_syscalls_stats(_): 'getpmsg', 'putmsg', 'putpmsg', + 'landlock_create_ruleset', + 'landlock_add_rule', + 'landlock_restrict_self', ] # populate with not implemented, reserved, unmaintained syscalls defined