[v4,2/5] Add CAP_MKNOD fallback in lapi/capability.h

Message ID	20240725-landlock-v4-2-66f5a1c0c693@suse.com
State	Changes Requested
Headers	show Return-Path: <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it> From: Andrea Cervesato <andrea.cervesato@suse.de> Date: Thu, 25 Jul 2024 11:23:12 +0200 MIME-Version: 1.0 Message-Id: <20240725-landlock-v4-2-66f5a1c0c693@suse.com> References: <20240725-landlock-v4-0-66f5a1c0c693@suse.com> In-Reply-To: <20240725-landlock-v4-0-66f5a1c0c693@suse.com> To: ltp@lists.linux.it default: False [-4.10 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email] Subject: [LTP] [PATCH v4 2/5] Add CAP_MKNOD fallback in lapi/capability.h Precedence: list Cc: mic@digikod.net, gnoack@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>
Series	landlock testing suite \| expand [v4,0/5] landlock testing suite [v4,1/5] Add landlock03 test [v4,2/5] Add CAP_MKNOD fallback in lapi/capability.h [v4,3/5] Add landlock04 test [v4,4/5] Add landlock05 test [v4,5/5] Add landlock06 test

Message ID

20240725-landlock-v4-2-66f5a1c0c693@suse.com

State

Changes Requested

Headers

From: Andrea Cervesato <andrea.cervesato@suse.de>
Date: Thu, 25 Jul 2024 11:23:12 +0200
MIME-Version: 1.0
Message-Id: <20240725-landlock-v4-2-66f5a1c0c693@suse.com>
References: <20240725-landlock-v4-0-66f5a1c0c693@suse.com>
In-Reply-To: <20240725-landlock-v4-0-66f5a1c0c693@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/5] Add CAP_MKNOD fallback in lapi/capability.h
Precedence: list
Cc: mic@digikod.net, gnoack@google.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it
Sender: "ltp" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>

Series

landlock testing suite | expand

Commit Message

Andrea Cervesato July 25, 2024, 9:23 a.m. UTC

From: Andrea Cervesato <andrea.cervesato@suse.com>

Reviewed-by: Li Wang <liwang@redhat.com>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 include/lapi/capability.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Petr Vorel July 26, 2024, 1:11 p.m. UTC | #1

Hi Andrea,

obviously correct. I suppose it was needed otherwise old distros would fail,
right? Go ahead and merge (probably together with landlock04.c where it is
needed).

Kind regards,
Petr

diff --git a/include/lapi/capability.h b/include/lapi/capability.h
index 2b593797c..0f317d6d7 100644
--- a/include/lapi/capability.h
+++ b/include/lapi/capability.h
@@ -44,14 +44,18 @@ 
 # define CAP_SYS_TIME         25
 #endif
 
-#ifndef CAP_AUDIT_READ
-# define CAP_AUDIT_READ       37
-#endif
-
 #ifndef CAP_SYS_RESOURCE
 # define CAP_SYS_RESOURCE     24
 #endif
 
+#ifndef CAP_MKNOD
+# define CAP_MKNOD            27
+#endif
+
+#ifndef CAP_AUDIT_READ
+# define CAP_AUDIT_READ       37
+#endif
+
 #ifndef CAP_BPF
 # define CAP_BPF              39
 #endif

[v4,2/5] Add CAP_MKNOD fallback in lapi/capability.h

Commit Message

Comments

Patch