From patchwork Wed Jul 24 09:45:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Cervesato X-Patchwork-Id: 1964215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i96ABX30; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Y9zSmmEp; dkim=fail reason="signature verification failed" (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i96ABX30; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Y9zSmmEp; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=patchwork.ozlabs.org) Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WTThF0Z9Kz1yXp for ; Wed, 24 Jul 2024 19:47:25 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D94713D1C34 for ; Wed, 24 Jul 2024 11:47:22 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 764683D1C08 for ; Wed, 24 Jul 2024 11:46:09 +0200 (CEST) Authentication-Results: in-7.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=andrea.cervesato@suse.de; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id C63E120012F for ; Wed, 24 Jul 2024 11:46:08 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BAEA721B27; Wed, 24 Jul 2024 09:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721814367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NrK0dT7lZhLSEhaTatUzOdVXTlDrMIblJ/fjBTHEYVM=; b=i96ABX30Ov8ZL76vNSndcK9/YMNVD5OwSl1xyjU9n2JU9APknwaFuQAxQi9MWlqMcs69Ke mQe5aScHf1AGxKSCKy2A76tF2mlrqXQa77lvdwPMGQqgvo9dTpRWVjielcGUfIhBSMbFVm ULCdASB/4DRRA2dOLsQ8zFkL5PJILSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721814367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NrK0dT7lZhLSEhaTatUzOdVXTlDrMIblJ/fjBTHEYVM=; b=Y9zSmmEpgybcpyShvmoQAnrPEWkHzuBbqHbxo6LjHQHAzik3tT4eBb0MBPTs9cUz+F89mo 8x9rsidKEMTzRcAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721814367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NrK0dT7lZhLSEhaTatUzOdVXTlDrMIblJ/fjBTHEYVM=; b=i96ABX30Ov8ZL76vNSndcK9/YMNVD5OwSl1xyjU9n2JU9APknwaFuQAxQi9MWlqMcs69Ke mQe5aScHf1AGxKSCKy2A76tF2mlrqXQa77lvdwPMGQqgvo9dTpRWVjielcGUfIhBSMbFVm ULCdASB/4DRRA2dOLsQ8zFkL5PJILSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721814367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NrK0dT7lZhLSEhaTatUzOdVXTlDrMIblJ/fjBTHEYVM=; b=Y9zSmmEpgybcpyShvmoQAnrPEWkHzuBbqHbxo6LjHQHAzik3tT4eBb0MBPTs9cUz+F89mo 8x9rsidKEMTzRcAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1FDA113411; Wed, 24 Jul 2024 09:46:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wKUbOF7NoGYxWwAAD6G6ig (envelope-from ); Wed, 24 Jul 2024 09:46:06 +0000 From: Andrea Cervesato Date: Wed, 24 Jul 2024 11:45:34 +0200 MIME-Version: 1.0 Message-Id: <20240724-fchmodat2-v3-4-1dc7cfc634b8@suse.com> References: <20240724-fchmodat2-v3-0-1dc7cfc634b8@suse.com> In-Reply-To: <20240724-fchmodat2-v3-0-1dc7cfc634b8@suse.com> To: ltp@lists.linux.it X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4524; i=andrea.cervesato@suse.com; h=from:subject:message-id; bh=uA89MOoxhJpTVqLDiOsJZcR3M+atTlwjV1H6cElX+Vc=; b=owEB7QES/pANAwAIAcvMGrIgs+ZGAcsmYgBmoM1EUmjMoBAETxIdpYSPBwV/0/Yp7D5sqaLMc AQQxxL2PN+JAbMEAAEIAB0WIQT1ysFzUKRW0sIb39jLzBqyILPmRgUCZqDNRAAKCRDLzBqyILPm Rt7RDACL8oV52B/bQx50vHiRY5Dp6IzgZPCyiJUr47yMa8kHw/9aCj7RiEEwr5yq0aX6aMnscoY Vw9UHU91+VQMpN76/dq7VQWHYzHoeHH/kej4ZSMJGF0Vjpgeq86w+Ws5KXB9Qm9JGw26cVnpSVl 9/riR4Z83dKhMfFUouGXwvTW4B129E4AhsFNV368LFStpQO7FIBXqAKi5vjm16lNDX64Qk/Ih6W cCcUnYjV3EPuRXQvO5Q8Hpp9941sXZhLPSc23ikM+arQoplPfLxkbGWz6U3RZLCbbziTDyNVyPQ plPWw2PhWCdNsxYNmJ4OLPFH4vWZp+DFM3m5aUn+SkgH8s2EEp4WjcWUDVFlz0TeILQUgtDvYVJ eb7tx/p+uL7YLu1iPWNBBtgkD81O2IPb7jzY/yGGwKCwRe3IsRdhjemxWxXXj5xSfHESBDlJ2JV AGxPftjlVJ117b2AWveGZMPf1INh1guulddljFF/2/TXXxnu4G+AYnVMW6rsKWCXTX5zI= X-Developer-Key: i=andrea.cervesato@suse.com; a=openpgp; fpr=F5CAC17350A456D2C21BDFD8CBCC1AB220B3E646 X-Spamd-Result: default: False [-4.10 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Score: -4.10 X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on in-7.smtp.seeweb.it X-Virus-Scanned: clamav-milter 1.0.3 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v3 4/5] Add fchmodat2_01 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" From: Andrea Cervesato This test verifies that fchmodat2() syscall is properly working with AT_SYMLINK_NOFOLLOW on regular files. Signed-off-by: Andrea Cervesato --- runtest/syscalls | 2 + testcases/kernel/syscalls/fchmodat2/.gitignore | 1 + testcases/kernel/syscalls/fchmodat2/Makefile | 7 ++ testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c | 114 +++++++++++++++++++++ 4 files changed, 124 insertions(+) diff --git a/runtest/syscalls b/runtest/syscalls index 27eb9a86b..b4bb4f391 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -265,6 +265,8 @@ fchmod06 fchmod06 fchmodat01 fchmodat01 fchmodat02 fchmodat02 +fchmodat2_01 fchmodat2_01 + fchown01 fchown01 fchown01_16 fchown01_16 fchown02 fchown02 diff --git a/testcases/kernel/syscalls/fchmodat2/.gitignore b/testcases/kernel/syscalls/fchmodat2/.gitignore new file mode 100644 index 000000000..47d5e2427 --- /dev/null +++ b/testcases/kernel/syscalls/fchmodat2/.gitignore @@ -0,0 +1 @@ +fchmodat2_01 diff --git a/testcases/kernel/syscalls/fchmodat2/Makefile b/testcases/kernel/syscalls/fchmodat2/Makefile new file mode 100644 index 000000000..8cf1b9024 --- /dev/null +++ b/testcases/kernel/syscalls/fchmodat2/Makefile @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2024 SUSE LLC Andrea Cervesato + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk +include $(top_srcdir)/include/mk/generic_leaf_target.mk diff --git a/testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c b/testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c new file mode 100644 index 000000000..a00c06bf5 --- /dev/null +++ b/testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c @@ -0,0 +1,114 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (C) 2024 SUSE LLC Andrea Cervesato + */ + +/*\ + * [Description] + * + * This test verifies that fchmodat2() syscall is properly working with + * AT_SYMLINK_NOFOLLOW regular files, symbolic links and directories. + */ + +#include "tst_test.h" +#include "tst_safe_file_at.h" +#include "lapi/fcntl.h" +#include "lapi/stat.h" + +#define MNTPOINT "mntpoint" +#define FNAME "myfile" +#define SNAME "symlink" +#define DNAME "mydir" +#define DNAME_PATH MNTPOINT"/"DNAME + +static int fd_dir = -1; + +static void verify_mode(int dirfd, const char *path, mode_t mode) +{ + struct stat st; + + SAFE_FSTATAT(dirfd, path, &st, AT_SYMLINK_NOFOLLOW); + TST_EXP_EQ_LI(st.st_mode, mode); +} + +static void test_regular_file(void) +{ + tst_res(TINFO, "Using regular files"); + + SAFE_CHMOD(MNTPOINT"/"FNAME, 0640); + + TST_EXP_PASS(fchmodat2(fd_dir, FNAME, 0700, 0)); + verify_mode(fd_dir, FNAME, S_IFREG | 0700); + + TST_EXP_PASS(fchmodat2(fd_dir, FNAME, 0700, AT_SYMLINK_NOFOLLOW)); + verify_mode(fd_dir, FNAME, S_IFREG | 0700); +} + +static void test_symbolic_link(void) +{ + tst_res(TINFO, "Using symbolic link"); + + TST_EXP_PASS(fchmodat2(fd_dir, SNAME, 0700, 0)); + verify_mode(fd_dir, FNAME, S_IFREG | 0700); + verify_mode(fd_dir, SNAME, S_IFLNK | 0777); + + TST_EXP_PASS(fchmodat2(fd_dir, SNAME, 0640, AT_SYMLINK_NOFOLLOW)); + verify_mode(fd_dir, FNAME, S_IFREG | 0700); + verify_mode(fd_dir, SNAME, S_IFLNK | 0640); +} + +static void test_empty_folder(void) +{ + tst_res(TINFO, "Using empty folder"); + + int fd; + + SAFE_CHMOD(DNAME_PATH, 0640); + fd = SAFE_OPEN(DNAME_PATH, O_PATH | O_DIRECTORY, 0640); + + TST_EXP_PASS(fchmodat2(fd, "", 0777, AT_EMPTY_PATH)); + verify_mode(fd_dir, DNAME, S_IFDIR | 0777); + + SAFE_CLOSE(fd); +} + +static void run(void) +{ + test_regular_file(); + test_empty_folder(); + test_symbolic_link(); +} + +static void setup(void) +{ + fd_dir = SAFE_OPEN(MNTPOINT, O_PATH | O_DIRECTORY, 0640); + + if (access(DNAME_PATH, F_OK) == -1) + SAFE_MKDIR(DNAME_PATH, 0640); + + SAFE_TOUCH(MNTPOINT"/"FNAME, 0640, NULL); + SAFE_SYMLINKAT(FNAME, fd_dir, SNAME); +} + +static void cleanup(void) +{ + SAFE_UNLINKAT(fd_dir, SNAME, 0); + SAFE_RMDIR(DNAME_PATH); + + if (fd_dir != -1) + SAFE_CLOSE(fd_dir); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .min_kver = "6.6", + .mntpoint = MNTPOINT, + .format_device = 1, + .all_filesystems = 1, + .skip_filesystems = (const char *const []) { + "fuse", + NULL + }, +};