diff mbox series

[v2,6/7] Add ioctl_ficlonerange02 test

Message ID 20240723-ioctl_ficlone-v2-6-33075bbc117f@suse.com
State Accepted
Headers show
Series Add ioctl_ficlone testing suite | expand

Commit Message

Andrea Cervesato July 23, 2024, 7:15 a.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

This test verifies that ioctl() FICLONERANGE feature correctly raises
EINVAL when:
- filesystem does not support overlapping reflink ranges in the same file
- filesystem does not support reflinking on bad blocks alignment

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/syscalls                                   |  1 +
 testcases/kernel/syscalls/ioctl/.gitignore         |  1 +
 .../kernel/syscalls/ioctl/ioctl_ficlonerange02.c   | 97 ++++++++++++++++++++++
 3 files changed, 99 insertions(+)

Comments

Cyril Hrubis July 24, 2024, 3:37 p.m. UTC | #1 
Hi!
Pushed with the same minor fixes as the previous patch.
diff mbox series

Patch

diff --git a/runtest/syscalls b/runtest/syscalls
index 1f050c5f5..4a73852e8 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -596,6 +596,7 @@  ioctl_ficlone01 ioctl_ficlone01
 ioctl_ficlone02 ioctl_ficlone02
 ioctl_ficlone03 ioctl_ficlone03
 ioctl_ficlonerange01 ioctl_ficlonerange01
+ioctl_ficlonerange02 ioctl_ficlonerange02
 
 inotify_init1_01 inotify_init1_01
 inotify_init1_02 inotify_init1_02
diff --git a/testcases/kernel/syscalls/ioctl/.gitignore b/testcases/kernel/syscalls/ioctl/.gitignore
index 08c015928..9f995b1ad 100644
--- a/testcases/kernel/syscalls/ioctl/.gitignore
+++ b/testcases/kernel/syscalls/ioctl/.gitignore
@@ -26,3 +26,4 @@ 
 /ioctl_ficlone02
 /ioctl_ficlone03
 /ioctl_ficlonerange01
+/ioctl_ficlonerange02
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange02.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange02.c
new file mode 100644
index 000000000..24666ebcc
--- /dev/null
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange02.c
@@ -0,0 +1,97 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
+ */
+
+/*\
+ * [Description]
+ *
+ * This test verifies that ioctl() FICLONERANGE feature correctly raises
+ * EINVAL when:
+ * - filesystem does not support overlapping reflink ranges in the same file
+ * - filesystem does not support reflinking on bad blocks alignment
+ */
+
+#include "tst_test.h"
+#include "lapi/fs.h"
+
+#define MNTPOINT "mnt"
+#define SRCPATH MNTPOINT "/file0"
+#define DSTPATH MNTPOINT "/file1"
+#define CHUNKS 10
+
+static struct file_clone_range *clone_range;
+static int filesize;
+static int alignment;
+static char *data;
+
+static void run(void)
+{
+	int src_fd;
+	int dst_fd;
+
+	src_fd = SAFE_OPEN(SRCPATH, O_CREAT | O_RDWR, 0640);
+	SAFE_WRITE(SAFE_WRITE_ALL, src_fd, data, filesize);
+	SAFE_FSYNC(src_fd);
+
+	dst_fd = SAFE_OPEN(DSTPATH, O_CREAT | O_RDWR, 0640);
+
+	clone_range->src_fd = dst_fd;
+	clone_range->src_offset = 0;
+	clone_range->src_length = filesize;
+	clone_range->dest_offset = 0;
+
+	TST_EXP_FAIL(ioctl(dst_fd, FICLONERANGE, clone_range), EINVAL,
+		"overlapping reflink ranges in the same file");
+
+	clone_range->src_fd = src_fd;
+	clone_range->src_offset = 0;
+	clone_range->src_length = alignment - 1;
+	clone_range->dest_offset = 0;
+
+	TST_EXP_FAIL(ioctl(dst_fd, FICLONERANGE, clone_range), EINVAL,
+		"bad blocks alignment");
+
+	SAFE_CLOSE(src_fd);
+	SAFE_CLOSE(dst_fd);
+}
+
+static void setup(void)
+{
+	struct stat sb;
+
+	SAFE_STAT(MNTPOINT, &sb);
+
+	alignment = sb.st_blksize;
+	filesize = alignment * CHUNKS;
+
+	data = (char *)SAFE_MALLOC(filesize);
+}
+
+static void cleanup(void)
+{
+	if (data)
+		free(data);
+}
+
+static struct tst_test test = {
+	.test_all = run,
+	.setup = setup,
+	.cleanup = cleanup,
+	.min_kver = "4.5",
+	.needs_root = 1,
+	.mount_device = 1,
+	.mntpoint = MNTPOINT,
+	.filesystems = (struct tst_fs []) {
+		{.type = "btrfs"},
+		{
+			.type = "xfs",
+			.mkfs_opts = (const char *const []) {"-m", "reflink=1", NULL},
+		},
+		{}
+	},
+	.bufs = (struct tst_buffers []) {
+		{&clone_range, .size = sizeof(struct file_clone_range)},
+		{},
+	}
+};