diff mbox series

[v2,5/7] Add ioctl_ficlonerange01 test

Message ID 20240723-ioctl_ficlone-v2-5-33075bbc117f@suse.com
State Accepted
Headers show
Series Add ioctl_ficlone testing suite | expand

Commit Message

Andrea Cervesato July 23, 2024, 7:15 a.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

This test verifies that ioctl() FICLONERANGE feature clones file
content from one file to an another.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/syscalls                                   |   1 +
 testcases/kernel/syscalls/ioctl/.gitignore         |   1 +
 .../kernel/syscalls/ioctl/ioctl_ficlonerange01.c   | 162 +++++++++++++++++++++
 3 files changed, 164 insertions(+)

Comments

Cyril Hrubis July 24, 2024, 3:24 p.m. UTC | #1 
Hi!
Pushed with a minor change, thanks.

> +static void cleanup(void)
> +{
> +	if (buff)
> +		free(buff);
> +
> +	if (data)
> +		free(data);

free(NULL) is no-op so I've removed the two ifs here.
Cyril Hrubis July 24, 2024, 3:34 p.m. UTC | #2 
Hi!
And also please avoid casting pointers from malloc(), that is something
you do in C++.
diff mbox series

Patch

diff --git a/runtest/syscalls b/runtest/syscalls
index 5aef2b97e..1f050c5f5 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -595,6 +595,7 @@  ioctl_sg01 ioctl_sg01
 ioctl_ficlone01 ioctl_ficlone01
 ioctl_ficlone02 ioctl_ficlone02
 ioctl_ficlone03 ioctl_ficlone03
+ioctl_ficlonerange01 ioctl_ficlonerange01
 
 inotify_init1_01 inotify_init1_01
 inotify_init1_02 inotify_init1_02
diff --git a/testcases/kernel/syscalls/ioctl/.gitignore b/testcases/kernel/syscalls/ioctl/.gitignore
index d0b470714..08c015928 100644
--- a/testcases/kernel/syscalls/ioctl/.gitignore
+++ b/testcases/kernel/syscalls/ioctl/.gitignore
@@ -25,3 +25,4 @@ 
 /ioctl_ficlone01
 /ioctl_ficlone02
 /ioctl_ficlone03
+/ioctl_ficlonerange01
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange01.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange01.c
new file mode 100644
index 000000000..122b7656f
--- /dev/null
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlonerange01.c
@@ -0,0 +1,162 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
+ */
+
+/*\
+ * [Description]
+ *
+ * This test verifies that ioctl() FICLONERANGE feature clones file content from
+ * one file to an another.
+ *
+ * [Algorithm]
+ *
+ * - populate source file
+ * - clone a portion of source content inside destination file
+ * - verify that source content portion has been cloned inside destination file
+ * - write a single byte inside destination file
+ * - verify that source content didn't change while destination did
+ */
+
+#include "tst_test.h"
+#include "lapi/fs.h"
+
+#define MNTPOINT "mnt"
+#define SRCPATH MNTPOINT "/file0"
+#define DSTPATH MNTPOINT "/file1"
+#define CHUNKS 64
+
+static struct file_clone_range *clone_range;
+static int filesize;
+static int offset;
+static int leftsize;
+static int src_fd = -1;
+static int dst_fd = -1;
+static char *data;
+static char *buff;
+
+static void run(void)
+{
+	struct stat src_stat;
+	struct stat dst_stat;
+
+	for (int i = 0; i < filesize; i++)
+		data[i] = 'a' + (rand() % 21);
+
+	src_fd = SAFE_OPEN(SRCPATH, O_CREAT | O_RDWR, 0640);
+	dst_fd = SAFE_OPEN(DSTPATH, O_CREAT | O_RDWR, 0640);
+
+	tst_res(TINFO, "Writing data inside src file");
+
+	SAFE_WRITE(SAFE_WRITE_ALL, src_fd, data, filesize);
+	SAFE_FSYNC(src_fd);
+
+	clone_range->src_fd = src_fd;
+	TST_EXP_PASS(ioctl(dst_fd, FICLONERANGE, clone_range));
+	if (TST_RET == -1)
+		return;
+
+	SAFE_FSYNC(dst_fd);
+
+	tst_res(TINFO, "Verifing that data is cloned between files");
+
+	SAFE_FSTAT(src_fd, &src_stat);
+	SAFE_FSTAT(dst_fd, &dst_stat);
+
+	TST_EXP_EXPR(src_stat.st_ino != dst_stat.st_ino,
+		"inode is different. %lu != %lu",
+		src_stat.st_ino,
+		dst_stat.st_ino);
+
+	TST_EXP_EQ_LI(src_stat.st_size, filesize);
+	TST_EXP_EQ_LI(dst_stat.st_size, leftsize);
+
+	SAFE_READ(0, dst_fd, buff, leftsize);
+
+	TST_EXP_EXPR(!strncmp(buff, data + offset, leftsize),
+		"dst file has been cloned (%d bytes)",
+		leftsize);
+
+	tst_res(TINFO, "Writing a byte inside dst file");
+
+	SAFE_LSEEK(dst_fd, 0, SEEK_SET);
+	SAFE_WRITE(SAFE_WRITE_ALL, dst_fd, "!", 1);
+	SAFE_FSYNC(dst_fd);
+
+	tst_res(TINFO, "Verifing that src file content didn't change");
+
+	SAFE_FSTAT(src_fd, &src_stat);
+	SAFE_FSTAT(dst_fd, &dst_stat);
+
+	TST_EXP_EQ_LI(src_stat.st_size, filesize);
+	TST_EXP_EQ_LI(dst_stat.st_size, leftsize);
+
+	SAFE_LSEEK(src_fd, 0, SEEK_SET);
+	SAFE_READ(0, src_fd, buff, filesize);
+
+	TST_EXP_EXPR(!strncmp(buff, data, filesize),
+		"src file content didn't change");
+
+	SAFE_CLOSE(src_fd);
+	SAFE_CLOSE(dst_fd);
+
+	SAFE_UNLINK(SRCPATH);
+	SAFE_UNLINK(DSTPATH);
+}
+
+static void setup(void)
+{
+	struct stat sb;
+
+	SAFE_STAT(MNTPOINT, &sb);
+
+	filesize = sb.st_blksize * CHUNKS;
+	offset = filesize / 4;
+	leftsize = filesize - offset;
+
+	clone_range->src_offset = offset;
+	clone_range->src_length = leftsize;
+	clone_range->dest_offset = 0;
+
+	data = (char *)SAFE_MALLOC(filesize);
+	buff = (char *)SAFE_MALLOC(filesize);
+
+	srand(time(NULL));
+}
+
+static void cleanup(void)
+{
+	if (buff)
+		free(buff);
+
+	if (data)
+		free(data);
+
+	if (src_fd != -1)
+		SAFE_CLOSE(src_fd);
+
+	if (dst_fd != -1)
+		SAFE_CLOSE(dst_fd);
+}
+
+static struct tst_test test = {
+	.test_all = run,
+	.setup = setup,
+	.cleanup = cleanup,
+	.min_kver = "4.5",
+	.needs_root = 1,
+	.mount_device = 1,
+	.mntpoint = MNTPOINT,
+	.filesystems = (struct tst_fs []) {
+		{.type = "btrfs"},
+		{
+			.type = "xfs",
+			.mkfs_opts = (const char *const []) {"-m", "reflink=1", NULL},
+		},
+		{}
+	},
+	.bufs = (struct tst_buffers []) {
+		{&clone_range, .size = sizeof(struct file_clone_range)},
+		{},
+	}
+};