| Message ID | 20240625100130.735643-1-liwang@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | msgstress01: remove TWARN type from runtime remaining | expand |
Hi! > Signed-off-by: Li Wang <liwang@redhat.com> > --- > testcases/kernel/syscalls/ipc/msgstress/msgstress01.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c > index 8b1e9a8c0..9f0ba105d 100644 > --- a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c > +++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c > @@ -214,7 +214,7 @@ static void run(void) > break; > > if (!tst_remaining_runtime()) { > - tst_res(TWARN, "Out of runtime during forking..."); > + tst_res(TINFO, "Warning: Out of runtime during forking..."); Maybe this should be a TCONF instead, since we were not able to run the test because the kernel is too slow... > *stop = 1; > break; > } > -- > 2.45.2 >
Cyril Hrubis <chrubis@suse.cz> wrote: > > --- a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c > > +++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c > > @@ -214,7 +214,7 @@ static void run(void) > > break; > > > > if (!tst_remaining_runtime()) { > > - tst_res(TWARN, "Out of runtime during forking..."); > > + tst_res(TINFO, "Warning: Out of runtime during > forking..."); > > Maybe this should be a TCONF instead, since we were not able to run the > test because the kernel is too slow... > Yeah, good point, once the '*stop' set to 1 the rest process doesn't get perform as well, so TCONF should be better.
diff --git a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c index 8b1e9a8c0..9f0ba105d 100644 --- a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c +++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c @@ -214,7 +214,7 @@ static void run(void) break; if (!tst_remaining_runtime()) { - tst_res(TWARN, "Out of runtime during forking..."); + tst_res(TINFO, "Warning: Out of runtime during forking..."); *stop = 1; break; }
To mask the issue where a warning is being treated as a failure in CI logs, we modify the code to change the message type from TWARN to TINFO. This warning easily happens especaill on debug/slower kernel: msgstress01.c:217: TWARN: Out of runtime during forking... Signed-off-by: Li Wang <liwang@redhat.com> --- testcases/kernel/syscalls/ipc/msgstress/msgstress01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)