diff mbox series

quotactl07: add _GNU_SOURCE define

Message ID 20240617033356.299491-1-liwang@redhat.com
State Accepted
Headers show
Series quotactl07: add _GNU_SOURCE define | expand

Commit Message

Li Wang June 17, 2024, 3:33 a.m. UTC
To get rid of error on implicit declaration (glibc-2.39):

 /usr/include/xfs/linux.h:188:15: error: implicit declaration of function
 ‘fallocate’; did you mean ‘alloca’? [-Wimplicit-function-declaration]
 188 |         ret = fallocate(fd, FALLOC_FL_ZERO_RANGE, start, len);
     |               ^~~~~~~~~
     |               alloca
 make: *** [../../../../include/mk/rules.mk:45: quotactl07]
 Error 1

Signed-off-by: Li Wang <liwang@redhat.com>
---
 testcases/kernel/syscalls/quotactl/quotactl07.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Wei Gao June 17, 2024, 11:23 p.m. UTC | #1
On Mon, Jun 17, 2024 at 11:33:56AM +0800, Li Wang wrote:
> To get rid of error on implicit declaration (glibc-2.39):
> 
>  /usr/include/xfs/linux.h:188:15: error: implicit declaration of function
>  ‘fallocate’; did you mean ‘alloca’? [-Wimplicit-function-declaration]
>  188 |         ret = fallocate(fd, FALLOC_FL_ZERO_RANGE, start, len);
>      |               ^~~~~~~~~
>      |               alloca
>  make: *** [../../../../include/mk/rules.mk:45: quotactl07]
>  Error 1
> 
> Signed-off-by: Li Wang <liwang@redhat.com>
> ---
>  testcases/kernel/syscalls/quotactl/quotactl07.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl07.c b/testcases/kernel/syscalls/quotactl/quotactl07.c
> index 34ff2705d..d8ad3760a 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl07.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl07.c
> @@ -13,6 +13,8 @@
>   * ("xfs: Sanity check flags of Q_XQUOTARM call").
>   */
>  
> +#define _GNU_SOURCE
> +#include <fcntl.h>
>  #include <errno.h>
>  #include <unistd.h>
>  #include <stdio.h>
> -- 
> 2.45.2
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by: Wei Gao <wegao@suse.com>
Petr Vorel June 19, 2024, 4:06 p.m. UTC | #2
Hi all,

workaround merged, thanks!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/quotactl/quotactl07.c b/testcases/kernel/syscalls/quotactl/quotactl07.c
index 34ff2705d..d8ad3760a 100644
--- a/testcases/kernel/syscalls/quotactl/quotactl07.c
+++ b/testcases/kernel/syscalls/quotactl/quotactl07.c
@@ -13,6 +13,8 @@ 
  * ("xfs: Sanity check flags of Q_XQUOTARM call").
  */
 
+#define _GNU_SOURCE
+#include <fcntl.h>
 #include <errno.h>
 #include <unistd.h>
 #include <stdio.h>