diff mbox series

[1/1] mmap15: Enable in compat mode

Message ID 20240506204324.63215-1-pvorel@suse.cz
State Accepted
Headers show
Series [1/1] mmap15: Enable in compat mode | expand

Commit Message

Petr Vorel May 6, 2024, 8:43 p.m. UTC 
Test actually runs well in compat mode. Skipping in 32 bit was
originally added bc8d45a43 (in 2004, in hugemmap03.c), likely kernel or
libc functionality changed.

Tested on recent 6.7 kernel and very old 4.4 kernel.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/mmap/mmap15.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Li Wang May 7, 2024, 1:29 a.m. UTC | #1 
On Tue, May 7, 2024 at 4:43 AM Petr Vorel <pvorel@suse.cz> wrote:

> Test actually runs well in compat mode. Skipping in 32 bit was
> originally added bc8d45a43 (in 2004, in hugemmap03.c), likely kernel or
> libc functionality changed.
>
> Tested on recent 6.7 kernel and very old 4.4 kernel.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>

Reviewed-by: Li Wang <liwang@redhat.com>


> ---
>  testcases/kernel/syscalls/mmap/mmap15.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/mmap/mmap15.c
> b/testcases/kernel/syscalls/mmap/mmap15.c
> index 71c18a10a..2128e0b57 100644
> --- a/testcases/kernel/syscalls/mmap/mmap15.c
> +++ b/testcases/kernel/syscalls/mmap/mmap15.c
> @@ -61,6 +61,5 @@ static struct tst_test test = {
>         .setup = setup,
>         .cleanup = cleanup,
>         .test_all = run,
> -       .skip_in_compat = 1,
>         .needs_tmpdir = 1
>  };
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
Petr Vorel May 7, 2024, 7:48 a.m. UTC | #2 
Hi Li,

thanks for your review, merged!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/mmap/mmap15.c b/testcases/kernel/syscalls/mmap/mmap15.c
index 71c18a10a..2128e0b57 100644
--- a/testcases/kernel/syscalls/mmap/mmap15.c
+++ b/testcases/kernel/syscalls/mmap/mmap15.c
@@ -61,6 +61,5 @@  static struct tst_test test = {
 	.setup = setup,
 	.cleanup = cleanup,
 	.test_all = run,
-	.skip_in_compat = 1,
 	.needs_tmpdir = 1
 };