diff mbox series

[v2] getrandom: Add negative tests for getrandom

Message ID 20240417092506.23625-1-xuyang2018.jy@fujitsu.com
State Accepted
Headers show
Series [v2] getrandom: Add negative tests for getrandom | expand

Commit Message

Yang Xu \(Fujitsu\) April 17, 2024, 9:25 a.m. UTC 
Add negative cases for getrandom(), when errno is EFAULT or EINVAL

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 runtest/syscalls                              |  1 +
 .../kernel/syscalls/getrandom/.gitignore      |  1 +
 .../kernel/syscalls/getrandom/getrandom05.c   | 45 +++++++++++++++++++
 3 files changed, 47 insertions(+)
 create mode 100644 testcases/kernel/syscalls/getrandom/getrandom05.c

Comments

Avinesh Kumar April 17, 2024, 1:20 p.m. UTC | #1 
Hi,

Reviewed-by: Avinesh Kumar <akumar@suse.de>

--
Thanks,
Avinesh
Petr Vorel April 23, 2024, 9:13 a.m. UTC | #2 
Hi Yang Xu, Avinesh,

FYI this broke in CI. Using <sys/random.h> without m4 check broke old libc
(glibc < 2.25 or musl < 1.1.20). I suggest to ignore kernel < 3.17 (we still
have 3.10 support in docs although it's not CI).

I'm on travelling, but I'll should manage to send patch today.

Kind regards,
Petr
diff mbox series

Patch

diff --git a/runtest/syscalls b/runtest/syscalls
index cc1e39c05..62eb4c1cd 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -504,6 +504,7 @@  getrandom01 getrandom01
 getrandom02 getrandom02
 getrandom03 getrandom03
 getrandom04 getrandom04
+getrandom05 getrandom05
 
 getresgid01 getresgid01
 getresgid01_16 getresgid01_16
diff --git a/testcases/kernel/syscalls/getrandom/.gitignore b/testcases/kernel/syscalls/getrandom/.gitignore
index ef06ece9d..e47d8b3f4 100644
--- a/testcases/kernel/syscalls/getrandom/.gitignore
+++ b/testcases/kernel/syscalls/getrandom/.gitignore
@@ -2,3 +2,4 @@ 
 /getrandom02
 /getrandom03
 /getrandom04
+/getrandom05
diff --git a/testcases/kernel/syscalls/getrandom/getrandom05.c b/testcases/kernel/syscalls/getrandom/getrandom05.c
new file mode 100644
index 000000000..1a9614330
--- /dev/null
+++ b/testcases/kernel/syscalls/getrandom/getrandom05.c
@@ -0,0 +1,45 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2024 FUJITSU LIMITED. All Rights Reserved.
+ * Author: Yang Xu <xuyang2018.jy@fujitsu.com>
+ */
+
+/*\
+ * [Description]
+ *
+ * Verify that getrandom(2) fails with
+ *
+ * - EFAULT when buf address is outside the accessible address space
+ * - EINVAL when flag is invalid
+ */
+
+#include <sys/random.h>
+#include "tst_test.h"
+
+static char buff_efault[64];
+static char buff_einval[64];
+
+static struct test_case_t {
+	char *buff;
+	size_t size;
+	unsigned int flag;
+	int expected_errno;
+	char *desc;
+} tcases[] = {
+	{(void *)-1, sizeof(buff_efault), 0, EFAULT,
+		"buf address is outside the accessible address space"},
+	{buff_einval, sizeof(buff_einval), -1, EINVAL, "flag is invalid"},
+};
+
+static void verify_getrandom(unsigned int i)
+{
+	struct test_case_t *tc = &tcases[i];
+
+	TST_EXP_FAIL2(getrandom(tc->buff, tc->size, tc->flag),
+		tc->expected_errno, "%s", tc->desc);
+}
+
+static struct tst_test test = {
+	.tcnt = ARRAY_SIZE(tcases),
+	.test = verify_getrandom,
+};