| Message ID | 20231107105836.68108-2-xuyang2018.jy@fujitsu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] link05: Convert docs to docparse | expand |
Hi Xu, > update copyright, fix grammar ... > +++ b/testcases/kernel/syscalls/link/link08.c > @@ -1,23 +1,26 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > * Copyright (c) 2014 Fujitsu Ltd. > + * Copyright (c) Linux Test Project, 2014-2023 > * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > */ > -/* > - * Test Description: > - * Verify that, > - * 1. link() fails with -1 return value and sets errno to EPERM > - * if oldpath is a directory. > - * 2. link() fails with -1 return value and sets errno to EXDEV > - * if oldpath and newpath are not on the same mounted file system( Linux > - * permits a file system to be mounted at multiple points, but link() > - * does not work across different mount points, even if the same > - * file system is mounted on both. ). > - * 3. link() fails with -1 return value and sets errno to EROFS > - * if the file is on a read-only file system. > - * 4. link() fails with -1 return value and sets errno to ELOOP > - * if too many symbolic links were encountered in resolving path. > + > +/*\ > + * [Description] > + * > + * Verify that, nit: * Verify that: Thanks! Reviewed-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr
Hi Petr, >Hi Xu, >> update copyright, fix grammar >... >> +++ b/testcases/kernel/syscalls/link/link08.c >> @@ -1,23 +1,26 @@ >> // SPDX-License-Identifier: GPL-2.0-or-later >> /* >> * Copyright (c) 2014 Fujitsu Ltd. >> + * Copyright (c) Linux Test Project, 2014-2023 >> * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com> >> */ >> -/* >> - * Test Description: >> - * Verify that, >> - * 1. link() fails with -1 return value and sets errno to EPERM >> - * if oldpath is a directory. >> - * 2. link() fails with -1 return value and sets errno to EXDEV >> - * if oldpath and newpath are not on the same mounted file system( Linux >> - * permits a file system to be mounted at multiple points, but link() >> - * does not work across different mount points, even if the same >> - * file system is mounted on both. ). >> - * 3. link() fails with -1 return value and sets errno to EROFS >> - * if the file is on a read-only file system. >> - * 4. link() fails with -1 return value and sets errno to ELOOP >> - * if too many symbolic links were encountered in resolving path. >> + >> +/*\ >> + * [Description] >> + * >> + * Verify that, >nit: * Verify that: >Thanks! >Reviewed-by: Petr Vorel <pvorel@suse.cz> Thanks for your suggestion, merged! Best Regards, Yang Xu >Kind regards, >Petr
diff --git a/testcases/kernel/syscalls/link/link08.c b/testcases/kernel/syscalls/link/link08.c index d3e33d077..9cc468f58 100644 --- a/testcases/kernel/syscalls/link/link08.c +++ b/testcases/kernel/syscalls/link/link08.c @@ -1,23 +1,26 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) 2014 Fujitsu Ltd. + * Copyright (c) Linux Test Project, 2014-2023 * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com> */ -/* - * Test Description: - * Verify that, - * 1. link() fails with -1 return value and sets errno to EPERM - * if oldpath is a directory. - * 2. link() fails with -1 return value and sets errno to EXDEV - * if oldpath and newpath are not on the same mounted file system( Linux - * permits a file system to be mounted at multiple points, but link() - * does not work across different mount points, even if the same - * file system is mounted on both. ). - * 3. link() fails with -1 return value and sets errno to EROFS - * if the file is on a read-only file system. - * 4. link() fails with -1 return value and sets errno to ELOOP - * if too many symbolic links were encountered in resolving path. + +/*\ + * [Description] + * + * Verify that, + * + * - link() fails with EPERM if the old path is a directory. + * - link() fails with EXDEV if the old path and the new path + * are not on the same mounted file system(Linux permits + * a file system to be mounted at multiple points, but link() + * does not work across different mount points, even if the same + * file system is mounted on both). + * - link() fails with EROFS if the file is on a read-only file system. + * - link() fails with ELOOP if too many symbolic links were encountered + * in resolving path. */ + #include <errno.h> #include "tst_test.h"