| Message ID | 20231107105836.68108-1-xuyang2018.jy@fujitsu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] link05: Convert docs to docparse | expand |
Hi Xu, > The description of link05's test has no relevance to the test code, > I've changed the description. > Reviewed-by: Petr Vorel <pvorel@suse.cz> > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> > --- > testcases/kernel/syscalls/link/link05.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c > index 95787ec24..f255bc13b 100644 > --- a/testcases/kernel/syscalls/link/link05.c > +++ b/testcases/kernel/syscalls/link/link05.c > @@ -1,13 +1,15 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved. > - * AUTHOR : Richard Logan > - * CO-PILOT : William Roske > + * Authors: Richard Logan, William Roske > * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz> > + * Copyright (c) Linux Test Project, 2001-2023 > */ +1 > -/* > - * Test if link(2) fails with EMLINK. > +/*\ > + * [Description] > + * > + * Tests that link(2) succeeds with creating n links. +1. I'd just instead of "n links" mention either "1000 links" or "high number of links" (to be more obvious). Kind regards, Petr > */ > #include <stdio.h>
Hi Petr >Hi Xu, >> The description of link05's test has no relevance to the test code, >> I've changed the description. >> Reviewed-by: Petr Vorel <pvorel@suse.cz> >> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> >> --- >> testcases/kernel/syscalls/link/link05.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c >> index 95787ec24..f255bc13b 100644 >> --- a/testcases/kernel/syscalls/link/link05.c >> +++ b/testcases/kernel/syscalls/link/link05.c >> @@ -1,13 +1,15 @@ >> // SPDX-License-Identifier: GPL-2.0-or-later >> /* >> * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved. >> - * AUTHOR : Richard Logan >> - * CO-PILOT : William Roske >> + * Authors: Richard Logan, William Roske >> * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz> >> + * Copyright (c) Linux Test Project, 2001-2023 >> */ >+1 >> -/* >> - * Test if link(2) fails with EMLINK. >> +/*\ >> + * [Description] >> + * >> + * Tests that link(2) succeeds with creating n links. >+1. I'd just instead of "n links" mention either "1000 links" or "high number of >links" (to be more obvious). Thanks for your suggestion, merged! >Kind regards, >Petr >> */ >> #include <stdio.h>
diff --git a/testcases/kernel/syscalls/link/link05.c b/testcases/kernel/syscalls/link/link05.c index 95787ec24..f255bc13b 100644 --- a/testcases/kernel/syscalls/link/link05.c +++ b/testcases/kernel/syscalls/link/link05.c @@ -1,13 +1,15 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved. - * AUTHOR : Richard Logan - * CO-PILOT : William Roske + * Authors: Richard Logan, William Roske * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz> + * Copyright (c) Linux Test Project, 2001-2023 */ -/* - * Test if link(2) fails with EMLINK. +/*\ + * [Description] + * + * Tests that link(2) succeeds with creating n links. */ #include <stdio.h>