From patchwork Wed Sep 6 08:09:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Cervesato X-Patchwork-Id: 1830245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nE/vwozc; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6bBqnqm2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=patchwork.ozlabs.org) Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RgZmY4KZPz1yh1 for ; Wed, 6 Sep 2023 18:10:05 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DDA1A3CC029 for ; Wed, 6 Sep 2023 10:09:55 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0AD413CB6EF for ; Wed, 6 Sep 2023 10:09:53 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 933F0200C2D for ; Wed, 6 Sep 2023 10:09:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1150B20290; Wed, 6 Sep 2023 08:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693987792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Cooxb8duYOnG/FNWPHF4dh811tvD3mtnJicyEzHq/J4=; b=nE/vwozcqIJbs07kma8unqHhuZmlEJBfZgyTINDJYULjQlGJqvN6NDYHOpBnSkWTw/rrKu vCXyiw3i+uKB0qqeEI9MCGqFeoLDYI5NXsUAULlWgaAzGoQewUKTfexLz0WmpFz7faB3Xf n1/sDIj9R3XeToOoeODWqCiyp6rnn/I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693987792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Cooxb8duYOnG/FNWPHF4dh811tvD3mtnJicyEzHq/J4=; b=6bBqnqm27eFHcfhah0G8D41lt08zq5cU1kUZzvKgZpir2C9EzIut8aNb026Ro4AaEDKRjS HrWeGxYH0DMRoQCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB34D1346C; Wed, 6 Sep 2023 08:09:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aTgeOM8z+GTWXAAAMHmgww (envelope-from ); Wed, 06 Sep 2023 08:09:51 +0000 From: Andrea Cervesato To: ltp@lists.linux.it Date: Wed, 6 Sep 2023 10:09:50 +0200 Message-Id: <20230906080950.23155-1-andrea.cervesato@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 1.0.1 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on in-7.smtp.seeweb.it Subject: [LTP] [PATCH v1] Refactor fork12 using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" From: Andrea Cervesato Signed-off-by: Andrea Cervesato --- testcases/kernel/syscalls/fork/fork12.c | 177 +++++++++--------------- 1 file changed, 62 insertions(+), 115 deletions(-) diff --git a/testcases/kernel/syscalls/fork/fork12.c b/testcases/kernel/syscalls/fork/fork12.c index 1c55c0c30..d8767859f 100644 --- a/testcases/kernel/syscalls/fork/fork12.c +++ b/testcases/kernel/syscalls/fork/fork12.c @@ -1,137 +1,84 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* - * Copyright (c) International Business Machines Corp., 2001 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See - * the GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA - * - * - * NAME - * fork12.c - * - * DESCRIPTION - * Check that all children inherit parent's file descriptor - * - * ALGORITHM - * Parent forks processes until -1 is returned.$ - * - * USAGE - * fork12 - * ** CAUTION ** Can hang your machine, esp prior to 2.4.19 - * - * HISTORY - * 07/2001 Ported by Wayne Boyer - * 07/2002 Split from fork07 as a test case to exhaust available pids. + * Copyright (c) International Business Machines Corp., 2001 + * 07/2001 Ported by Wayne Boyer + * Copyright (C) 2023 SUSE LLC Andrea Cervesato + */ +/*\ + *[Description] * - * RESTRICTIONS - * Should be run as root to avoid resource limits.$ - * Should not be run with other test programs because it tries to - * use all available pids. + * This test spawns multiple processes inside a child, until fork() returns -1. + * Then we check if EAGAIN is raised. */ -#include +#include #include -#include -#include -#include "test.h" -#include "safe_macros.h" - -char *TCID = "fork12"; -int TST_TOTAL = 1; +#include "tst_test.h" -static void setup(void); -static void cleanup(void); -static void fork12_sigs(int signum); +static pid_t child_pid; -int main(int ac, char **av) +static void start_forking(void) { - int forks, pid1, fork_errno, waitstatus; - int ret, status; - int lc; - - tst_parse_opts(ac, av, NULL, NULL); - - setup(); - - for (lc = 0; TEST_LOOPING(lc); lc++) { - tst_count = 0; - - tst_resm(TINFO, "Forking as many kids as possible"); - forks = 0; - while ((pid1 = fork()) != -1) { - if (pid1 == 0) { /* child */ - /* - * Taunt the OOM killer so that it doesn't - * kill system processes - */ - SAFE_FILE_PRINTF(NULL, - "/proc/self/oom_score_adj", "500"); - pause(); - exit(0); - } - forks++; - ret = SAFE_WAITPID(cleanup, -1, &status, WNOHANG); - if (ret > 0) { - /* a child may be killed by OOM killer */ - if (WTERMSIG(status) == SIGKILL) - break; - tst_brkm(TBROK, cleanup, - "child exit with error code %d or signal %d", - WEXITSTATUS(status), WTERMSIG(status)); - } + pid_t pid; + int status; + int forks = 1; + + tst_res(TINFO, "Forking as many children as possible"); + + while (1) { + TEST(fork()); + pid = TST_RET; + + if (pid == -1) + break; + + if (!pid) { + /* + * Taunt the OOM killer so that it doesn't + * kill system processes + */ + SAFE_FILE_PRINTF("/proc/self/oom_score_adj", "500"); + pause(); + exit(0); } - fork_errno = errno; - - /* parent */ - tst_resm(TINFO, "Number of processes forked is %d", forks); - tst_resm(TPASS, "fork() eventually failed with %d: %s", - fork_errno, strerror(fork_errno)); - /* collect our kids */ - /* - * Introducing a sleep(3) to make sure all children are - * at pause() when SIGQUIT is sent to them - */ - sleep(3); - kill(0, SIGQUIT); - while (wait(&waitstatus) > 0) ; + forks++; + + if (SAFE_WAITPID(-1, &status, WNOHANG) > 0) { + tst_brk(TBROK, "child exit with error code %d or signal %d", + WEXITSTATUS(status), + WTERMSIG(status)); + } } - cleanup(); - tst_exit(); + tst_res(TINFO, "Number of processes forked is %d", forks); + TST_EXP_EXPR(TST_ERR == EAGAIN, "last fork() failed with EAGAIN"); } -static void setup(void) +static void run(void) { - tst_sig(FORK, fork12_sigs, cleanup); - TEST_PAUSE; + int status; + + child_pid = SAFE_FORK(); + if (!child_pid) { + start_forking(); + return; + } + + SAFE_WAIT(&status); } static void cleanup(void) { - int waitstatus; + kill(child_pid, 0); - /* collect our kids */ - kill(0, SIGQUIT); - while (wait(&waitstatus) > 0) ; + if (errno != ESRCH) + SAFE_KILL(child_pid, SIGKILL); } -static void fork12_sigs(int signum) -{ - if (signum == SIGQUIT) { - /* Children will continue, parent will ignore */ - } else { - tst_brkm(TBROK, cleanup, - "Unexpected signal %d received.", signum); - } -} +static struct tst_test test = { + .test_all = run, + .cleanup = cleanup, + .forks_child = 1, + .max_runtime = 600, +};