| Message ID | 20230721123852.1420080-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] nfs_lib.sh: Set NFS 4.2 on TCP as the default | expand |
Hi all, > Previously NFS 3 on UDP was the default, which leaded to test being > skipped when tests run without parameters: > TCONF: UDP support disabled on NFS server > This does not have an effect when tests run properly via > runtest/net.nfs, which specify parameters. It just safes typing > -t tcp (and optionally -v 4.2) when one runs single test manually. FYI patch merged. Kind regards, Petr > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > Hi, > I'm pretty sure, we don't want to have UDP as the default (besides > skipped with TCONF it was acked by Jeff [1]). But I wonder if NFS 4.2 is > the best as the default version. Maybe just 4 or 4.1? > Kind regards, > Petr > [1] https://lore.kernel.org/ltp/e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org/ > testcases/network/nfs/nfs_stress/nfs_lib.sh | 4 ++-- ... > -VERSION=${VERSION:=3} > +VERSION=${VERSION:=4.2} > NFILES=${NFILES:=1000} > -SOCKET_TYPE="${SOCKET_TYPE:-udp}" > +SOCKET_TYPE="${SOCKET_TYPE:-tcp}"
diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh index abf7ba5a2..dae15a2e1 100644 --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh @@ -4,9 +4,9 @@ # Copyright (c) 2015-2018 Oracle and/or its affiliates. All Rights Reserved. # Copyright (c) International Business Machines Corp., 2001 -VERSION=${VERSION:=3} +VERSION=${VERSION:=4.2} NFILES=${NFILES:=1000} -SOCKET_TYPE="${SOCKET_TYPE:-udp}" +SOCKET_TYPE="${SOCKET_TYPE:-tcp}" NFS_TYPE=${NFS_TYPE:=nfs} nfs_usage()
Previously NFS 3 on UDP was the default, which leaded to test being skipped when tests run without parameters: TCONF: UDP support disabled on NFS server This does not have an effect when tests run properly via runtest/net.nfs, which specify parameters. It just safes typing -t tcp (and optionally -v 4.2) when one runs single test manually. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Hi, I'm pretty sure, we don't want to have UDP as the default (besides skipped with TCONF it was acked by Jeff [1]). But I wonder if NFS 4.2 is the best as the default version. Maybe just 4 or 4.1? Kind regards, Petr [1] https://lore.kernel.org/ltp/e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org/ testcases/network/nfs/nfs_stress/nfs_lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)