From patchwork Mon Mar 20 22:37:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Liaw X-Patchwork-Id: 1759245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=GdQwmhaR; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PgV4Q4SsHz246f for ; Tue, 21 Mar 2023 09:37:58 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 63F863CAA88 for ; Mon, 20 Mar 2023 23:37:56 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id BCDD93CACD8 for ; Mon, 20 Mar 2023 23:37:36 +0100 (CET) Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 0CF5C1000772 for ; Mon, 20 Mar 2023 23:37:36 +0100 (CET) Received: by mail-pl1-x64a.google.com with SMTP id z14-20020a170903018e00b001a1a2bee58dso6706691plg.3 for ; Mon, 20 Mar 2023 15:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679351854; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pi6ZbuljnlMIkXomu9Dc1K6gA+NTa1EUTD4h4S/0Xms=; b=GdQwmhaRPd8hZjpPE+25+wvIb67vuUsWMZYROF5ReYBSWTxoVbV/mp69jZ4gIpRD5y 7DJ0ujnybE9XfDK2p2AJwNh41aTkv9LSrnUrcJk8wW91+DYMDn7N0qMWZN5s/f6uu7gz QAulrhdm1jTVK19SRUI4ZJt6XGYgTQL0fFhvXB18EQ/zFsHEIQsy2xmaV4zzroHi/Axw Dfd+0upHRKMz9/d+0+02TMGJmQfL6OcKKYxjsDtdd8/d4HQdxlBISMxi/oeISPRNMH/M fU/7y9ae0WWTJPMfdTkoEbULqpdO1flki4WMxgB8tRtmKVhexhSiCCTCLMsObVztum4n hxRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679351854; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pi6ZbuljnlMIkXomu9Dc1K6gA+NTa1EUTD4h4S/0Xms=; b=6N9CWHrbay1gmQD9KdzhDOYtfPtnyAwX9Bb3Q4NvHGj9g5k7dKgEwIvxmmrTVfG6gb eSBENX49zvGqlFpItn4k0svrraTirfvRPZVBuPQ84MvQxdcMuobqFYtRU/qxEbJUTvUV Tk9Y3YxZ+B4dUPBf7R1KnhHm5Ri1LSXr4sDx6RNW8a5JCRHx9KILIAvO//FbwnNsR6zD iBPm8AcdWdDHC5yj6+A8bpolc8dpJYHeh7UA9JvM/4JlBTDxxBclqOP0XwqIYpPN4ry/ /j2c8+/sqP8ooqOe6MMFMHnHFFGzQm5AFPJu9wf55Gimjvyt8/i2j5rQ8f3VDindrwAv 83cw== X-Gm-Message-State: AO0yUKV1sIX9m1UB4BR+9BB4mWGAJf/7T7dZldvcKy7dSW5pYgGpVAxS zNJsTGYJh1h3BvYqVv/ibMzi3ZN5cJDGAj6brfO2YmzPE8h0HxxJmsUTTLgTE9kKTgHetq85TRn Qomc3AZv0pe1h6zm5CZJS8TW9szWz/z3IGujtIVkA8uhi5AozO0FibqfC X-Google-Smtp-Source: AK7set9WIhsa9SLtY50StgTg+GNTJXiBGc45V5KS6lCD8/r/e/fnri3tGVEP4oBhTNMX2L3j3JP9mS6OGsA= X-Received: from edliaw.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:305d]) (user=edliaw job=sendgmr) by 2002:a65:4501:0:b0:50a:592b:25ba with SMTP id n1-20020a654501000000b0050a592b25bamr82345pgq.3.1679351854486; Mon, 20 Mar 2023 15:37:34 -0700 (PDT) Date: Mon, 20 Mar 2023 22:37:22 +0000 In-Reply-To: <20230320223723.2030960-1-edliaw@google.com> Mime-Version: 1.0 References: <20230320223723.2030960-1-edliaw@google.com> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog Message-ID: <20230320223723.2030960-3-edliaw@google.com> To: ltp@lists.linux.it X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-7.4 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-4.smtp.seeweb.it Subject: [LTP] [PATCH v1 2/3] set_dev_loop_path: Refactor set_dev_path and check return value X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Edward Liaw via ltp From: Edward Liaw Reply-To: Edward Liaw Cc: kernel-team@android.com Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" tst_find_free_loopdev does not check the return value of set_dev_path and will return the last attempted path even if it does not pass a stat check. set_dev_path also has a return value that is not consistent with the other functions in this file. Renames the function to set_dev_loop_path, the const array to dev_loop_variants and changes the return value to 0 on success and 1 on failure. Check the return value when called in tst_find_free_loopdev for failure to acquire a loop device. Signed-off-by: Edward Liaw --- lib/tst_device.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/tst_device.c b/lib/tst_device.c index a61c5a748..ae665f7b6 100644 --- a/lib/tst_device.c +++ b/lib/tst_device.c @@ -54,25 +54,25 @@ static char dev_path[PATH_MAX]; static int device_acquired; static unsigned long prev_dev_sec_write; -static const char *dev_variants[] = { +static const char *dev_loop_variants[] = { "/dev/loop%i", "/dev/loop/%i", "/dev/block/loop%i" }; -static int set_dev_path(int dev, char *path, size_t path_len) +static int set_dev_loop_path(int dev, char *path, size_t path_len) { unsigned int i; struct stat st; - for (i = 0; i < ARRAY_SIZE(dev_variants); i++) { - snprintf(path, path_len, dev_variants[i], dev); + for (i = 0; i < ARRAY_SIZE(dev_loop_variants); i++) { + snprintf(path, path_len, dev_loop_variants[i], dev); if (stat(path, &st) == 0 && S_ISBLK(st.st_mode)) - return 1; + return 0; } - return 0; + return 1; } int tst_find_free_loopdev(char *path, size_t path_len) @@ -88,8 +88,8 @@ int tst_find_free_loopdev(char *path, size_t path_len) rc = ioctl(ctl_fd, LOOP_CTL_GET_FREE); close(ctl_fd); if (rc >= 0) { - if (path) - set_dev_path(rc, path, path_len); + if (!path || set_dev_loop_path(rc, path, path_len) != 0) + tst_brkm(TBROK, NULL, "Could not stat loop device %i", rc); tst_resm(TINFO, "Found free device %d '%s'", rc, path ?: ""); return rc; @@ -116,7 +116,7 @@ int tst_find_free_loopdev(char *path, size_t path_len) */ for (i = 0; i < 256; i++) { - if (!set_dev_path(i, buf, sizeof(buf))) + if (set_dev_loop_path(i, buf, sizeof(buf)) != 0) continue; dev_fd = open(buf, O_RDONLY);