From patchwork Fri Mar 25 12:54:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Cervesato X-Patchwork-Id: 1609430 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bmSfY2lf; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qMpbfQ/g; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KQ2Bk0NnXz9s07 for ; Fri, 25 Mar 2022 23:55:42 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8E61A3C8F91 for ; Fri, 25 Mar 2022 13:55:39 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A04C33C6574 for ; Fri, 25 Mar 2022 13:54:48 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id B8EB8100113F for ; Fri, 25 Mar 2022 13:54:47 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48521210F1; Fri, 25 Mar 2022 12:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1648212887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c35/Pq/SNMQuQKVHAwG5eEVBU1zhwHFvikRuk4Wrzic=; b=bmSfY2lfHFykDmPWtUWvvON2D+/8/pdRw/ZS/YHrAeOgfqbj+jzHZkTYp7qMLqylpLbWE1 pRYmXvQvOoKlO20a5czoenfz8UaEAmRoYqVPom7iq++haamdOyAX6fttL8ziUxbUrRPRZY ag+gi2LOp49gX2y8YnuiqOICY4B2Ak0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1648212887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c35/Pq/SNMQuQKVHAwG5eEVBU1zhwHFvikRuk4Wrzic=; b=qMpbfQ/gNB4SPxrjYgxgYXt6IS5y0xcubNKdsnQ5/x59QFqxJ8h2mk00RByS7Wm19o0B5f wPbqxyLZMaV3gmDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 20CDA1332D; Fri, 25 Mar 2022 12:54:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cCUtBpe7PWKoZgAAMHmgww (envelope-from ); Fri, 25 Mar 2022 12:54:47 +0000 From: Andrea Cervesato To: ltp@lists.linux.it Date: Fri, 25 Mar 2022 13:54:38 +0100 Message-Id: <20220325125445.11984-4-andrea.cervesato@suse.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220325125445.11984-1-andrea.cervesato@suse.de> References: <20220325125445.11984-1-andrea.cervesato@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-4.smtp.seeweb.it Subject: [LTP] [PATCH v4 03/10] Rewrite sem_comm.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Signed-off-by: Andrea Cervesato --- .../kernel/containers/sysvipc/sem_comm.c | 178 +++++------------- 1 file changed, 52 insertions(+), 126 deletions(-) diff --git a/testcases/kernel/containers/sysvipc/sem_comm.c b/testcases/kernel/containers/sysvipc/sem_comm.c index a2c354a08..de548d3ec 100644 --- a/testcases/kernel/containers/sysvipc/sem_comm.c +++ b/testcases/kernel/containers/sysvipc/sem_comm.c @@ -1,20 +1,16 @@ -/* Copyright (c) 2014 Red Hat, Inc. - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of version 2 the GNU General Public License as - * published by the Free Software Foundation. +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2014 Red Hat, Inc. + * Copyright (C) 2022 SUSE LLC Andrea Cervesato + */ + +/*\ + * [Description] * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * Test SysV IPC semaphore usage between cloned processes. * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - *********************************************************************** - * File: sem_comm.c + * [Algorithm] * - * Description: * 1. Clones two child processes with CLONE_NEWIPC flag, each child * creates System V semaphore (sem) with the _identical_ key. * 2. Child1 locks the semaphore. @@ -26,166 +22,96 @@ */ #define _GNU_SOURCE -#include -#include + #include -#include -#include -#include "ipcns_helper.h" -#include "test.h" -#include "safe_macros.h" +#include +#include +#include "tst_safe_sysv_ipc.h" +#include "tst_test.h" #include "lapi/sem.h" +#include "common.h" #define TESTKEY 124426L -char *TCID = "sem_comm"; -int TST_TOTAL = 1; -static void cleanup(void) -{ - tst_rmdir(); -} - -static void setup(void) -{ - tst_require_root(); - check_newipc(); - tst_tmpdir(); - TST_CHECKPOINT_INIT(tst_rmdir); -} - -int chld1_sem(void *arg) +static int chld1_sem(LTP_ATTRIBUTE_UNUSED void *arg) { int id; union semun su; struct sembuf sm; - id = semget(TESTKEY, 1, IPC_CREAT); - if (id == -1) { - perror("semget"); - return 2; - } + id = SAFE_SEMGET(TESTKEY, 1, IPC_CREAT); su.val = 1; - if (semctl(id, 0, SETVAL, su) == -1) { - perror("semctl"); - semctl(id, 0, IPC_RMID); - return 2; - } + SAFE_SEMCTL(id, 0, SETVAL, su); /* tell child2 to continue and wait for it to create the semaphore */ - TST_SAFE_CHECKPOINT_WAKE_AND_WAIT(NULL, 0); + TST_CHECKPOINT_WAKE_AND_WAIT(0); sm.sem_num = 0; sm.sem_op = -1; sm.sem_flg = IPC_NOWAIT; - if (semop(id, &sm, 1) == -1) { - perror("semop"); - semctl(id, 0, IPC_RMID); - return 2; - } + SAFE_SEMOP(id, &sm, 1); /* tell child2 to continue and wait for it to lock the semaphore */ - TST_SAFE_CHECKPOINT_WAKE_AND_WAIT(NULL, 0); + TST_CHECKPOINT_WAKE_AND_WAIT(0); - sm.sem_op = 1; - semop(id, &sm, 1); + SAFE_SEMCTL(id, 0, IPC_RMID); - semctl(id, 0, IPC_RMID); return 0; } -int chld2_sem(void *arg) +static int chld2_sem(LTP_ATTRIBUTE_UNUSED void *arg) { - int id, rval = 0; + int id; struct sembuf sm; union semun su; /* wait for child1 to create the semaphore */ - TST_SAFE_CHECKPOINT_WAIT(NULL, 0); + TST_CHECKPOINT_WAIT(0); - id = semget(TESTKEY, 1, IPC_CREAT); - if (id == -1) { - perror("semget"); - return 2; - } + id = SAFE_SEMGET(TESTKEY, 1, IPC_CREAT); su.val = 1; - if (semctl(id, 0, SETVAL, su) == -1) { - perror("semctl"); - semctl(id, 0, IPC_RMID); - return 2; - } + SAFE_SEMCTL(id, 0, SETVAL, su); /* tell child1 to continue and wait for it to lock the semaphore */ - TST_SAFE_CHECKPOINT_WAKE_AND_WAIT(NULL, 0); + TST_CHECKPOINT_WAKE_AND_WAIT(0); sm.sem_num = 0; sm.sem_op = -1; sm.sem_flg = IPC_NOWAIT; - if (semop(id, &sm, 1) == -1) { - if (errno == EAGAIN) { - rval = 1; - } else { - perror("semop"); - semctl(id, 0, IPC_RMID); - return 2; - } + TEST(semop(id, &sm, 1)); + if (TST_RET < 0) { + if (TST_ERR != EAGAIN) + tst_brk(TBROK | TERRNO, "semop error"); + + tst_res(TFAIL, "semaphore decremented from different namespace"); + } else { + tst_res(TPASS, "semaphore has not been decremented"); } /* tell child1 to continue */ - TST_SAFE_CHECKPOINT_WAKE(NULL, 0); + TST_CHECKPOINT_WAKE(0); - sm.sem_op = 1; - semop(id, &sm, 1); + SAFE_SEMCTL(id, 0, IPC_RMID); - semctl(id, 0, IPC_RMID); - return rval; + return 0; } -static void test(void) +static void run(void) { - int status, ret = 0; - - ret = do_clone_unshare_test(T_CLONE, CLONE_NEWIPC, chld1_sem, NULL); - if (ret == -1) - tst_brkm(TBROK | TERRNO, cleanup, "clone failed"); - - ret = do_clone_unshare_test(T_CLONE, CLONE_NEWIPC, chld2_sem, NULL); - if (ret == -1) - tst_brkm(TBROK | TERRNO, cleanup, "clone failed"); - - - while (wait(&status) > 0) { - if (WIFEXITED(status) && WEXITSTATUS(status) == 1) - ret = 1; - if (WIFEXITED(status) && WEXITSTATUS(status) == 2) - tst_brkm(TBROK | TERRNO, cleanup, "error in child"); - if (WIFSIGNALED(status)) { - tst_resm(TFAIL, "child was killed with signal %s", - tst_strsig(WTERMSIG(status))); - return; - } - } - - if (ret) - tst_resm(TFAIL, "SysV sem: communication with identical keys" - " between namespaces"); - else - tst_resm(TPASS, "SysV sem: communication with identical keys" - " between namespaces"); + clone_unshare_test(T_CLONE, CLONE_NEWIPC, chld1_sem, NULL); + clone_unshare_test(T_CLONE, CLONE_NEWIPC, chld2_sem, NULL); } -int main(int argc, char *argv[]) +static void setup(void) { - int lc; - - tst_parse_opts(argc, argv, NULL, NULL); - - setup(); - - for (lc = 0; TEST_LOOPING(lc); lc++) - test(); - - cleanup(); - tst_exit(); + check_newipc(); } + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .needs_root = 1, + .needs_checkpoints = 1, +};